Skip to content

mbed add does not ignore "*.lib" files inside ".mbedignore" paths #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bremoran opened this issue Dec 19, 2016 · 4 comments
Closed

mbed add does not ignore "*.lib" files inside ".mbedignore" paths #407

bremoran opened this issue Dec 19, 2016 · 4 comments

Comments

@bremoran
Copy link
Contributor

bremoran commented Dec 19, 2016

I have a repo with both a KiCAD PCB design (which contains *.lib files) and a library for using the PCB in it. This causes a lot of spurious output from mbed add:

$ mbed add [email protected]:ARMmbed/power-cut-jig.git --protocol ssh
[mbed] Adding library "power-cut-jig.git" from "ssh://[email protected]/ARMmbed/power-cut-jig.git" at latest revision in the current branch
[mbed] WARNING: File "jig-b-cache.lib" in "/Users/bremor01/dev/experiments/addlib/power-cut-jig.git/jig-pcb" uses a non-standard .lib file extension, which is not compatible with the mbed build tools.
---
[mbed] WARNING: File "power-jig.lib" in "/Users/bremor01/dev/experiments/addlib/power-cut-jig.git/jig-pcb" uses a non-standard .lib file extension, which is not compatible with the mbed build tools.
---
[mbed] WARNING: File "jig-b-cache.lib" in "/Users/bremor01/dev/experiments/addlib/power-cut-jig.git/jig-pcb" uses a non-standard .lib file extension, which is not compatible with the mbed build tools.
---
[mbed] WARNING: File "power-jig.lib" in "/Users/bremor01/dev/experiments/addlib/power-cut-jig.git/jig-pcb" uses a non-standard .lib file extension, which is not compatible with the mbed build tools.
---
[mbed] WARNING: File "jig-b-cache.lib" in "/Users/bremor01/dev/experiments/addlib/power-cut-jig.git/jig-pcb" uses a non-standard .lib file extension, which is not compatible with the mbed build tools.
---
[mbed] WARNING: File "power-jig.lib" in "/Users/bremor01/dev/experiments/addlib/power-cut-jig.git/jig-pcb" uses a non-standard .lib file extension, which is not compatible with the mbed build tools.
---
[mbed] Updating reference "power-cut-jig.git" -> "https://github.com/ARMmbed/power-cut-jig/#416de319667fbfacfc12f858e85104d2f25bb78f"
@bridadan
Copy link
Contributor

bridadan commented Dec 19, 2016

Hmmm, maybe we should make these warning messages appear only when verbose (-v) is enabled. Any thoughts @screamerbg, @bremoran ?
[Mirrored to Jira]

@bremoran
Copy link
Contributor Author

bremoran commented Dec 19, 2016

@bridadan it would be less of a problem if the .mbedignore were respected by all of the mbed * commands.
[Mirrored to Jira]

@seppestas
Copy link

seppestas commented Aug 8, 2017

Having the mbed library commands respect what's in the .mbedignore file would also solve some issues with these commands pulling in mbed-os in libraries, see #472 and #473.

In my example, having mbed add and mbed deploy respect the contents of .mbedignore would make it possible to add e.g an EXAMPLE folder to a library and put "EXAMPLE/*" in the .mbedignore file preventing libraries in the EXAMPLE folder (like mbed-os) from being pulled in and compiled when using the library.

In this case, if someone wants to run the example for testing / developing, it would be possible to simply cd into the EXAMPLE folder and run the mbed commands there, causing it not to see the .mbedignore file at the root of the library.
[Mirrored to Jira]

@ARMmbed ARMmbed deleted a comment from ciarmcom Oct 2, 2018
jupe pushed a commit to PelionIoT/mbed-trace that referenced this issue Dec 31, 2018
jupe pushed a commit to PelionIoT/mbed-trace that referenced this issue Dec 31, 2018
* build mbed-os5 test app
* workarounds for ARMmbed/mbed-cli#407
@ciarmcom
Copy link
Member

Thank you for raising this issue. Please note we have updated our policies and
now only defects should be raised directly in GitHub. Going forward questions and
enhancements will be considered in our forums, https://forums.mbed.com/ . If this
issue is still relevant please re-raise it there.
This GitHub issue will now be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants