Skip to content

Sheet may be displayed on the wrong window (or not displayed) #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stuartmorgan-g opened this issue Jan 21, 2025 · 1 comment · Fixed by #7
Closed

Sheet may be displayed on the wrong window (or not displayed) #4

stuartmorgan-g opened this issue Jan 21, 2025 · 1 comment · Fixed by #7
Assignees
@EchoEllet
Labels
bug Something isn't working

Comments

@stuartmorgan-g
Copy link

This code is not the right way to get the window containing a Flutter view in a plugin; there is no guarantee that a) there is a key window, or b) that the key window is the window with the Flutter view.

Instead, plugins should get the window of the view returned by the plugin registrar. See file_selector for an example of reliably getting the correct window.
@EchoEllet EchoEllet self-assigned this Jan 21, 2025
EchoEllet added a commit that referenced this issue Jan 21, 2025
@EchoEllet
fix: sheet is smaller than expected #2, or might be displayed on the …
8d45c9a 
…wrong window (or not displayed) #4
@EchoEllet EchoEllet added the bug Something isn't working label Jan 21, 2025
EchoEllet added a commit that referenced this issue Jan 21, 2025
@EchoEllet
fix: sheet is smaller than expected #2, or might be displayed on the …
5647462 
…wrong window (or not displayed) #4
@EchoEllet EchoEllet mentioned this issue Jan 21, 2025
Merged
EchoEllet added a commit that referenced this issue Jan 22, 2025
@EchoEllet
fix: sheet is too small, or might be displayed on the wrong window (#7)
f4f4d21 
* fix: the sheet is smaller than expected #2, or might be displayed on the wrong window #4

* docs: remove known issue from README

* chore: set sheet min-content size

* chore: set fixed initial sheet size
@EchoEllet EchoEllet linked a pull request Jan 22, 2025 that will close this issue
fix: sheet is too small, or might be displayed on the wrong window #7
Merged
@EchoEllet
Copy link
Contributor

Thanks again for the detailed report!

I expected these issues as I'm familiar with Java/Kotlin for Android, but not with macOS, iOS, or the Apple ecosystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EchoEllet EchoEllet

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@stuartmorgan-g @EchoEllet