Skip to content

Commit 4693934

Browse files
api-clients-generation-pipeline[bot]ci.datadog-api-spec
and
ci.datadog-api-spec
authored
Fix maxSignalDuration third party (#2142)
Co-authored-by: ci.datadog-api-spec <[email protected]> Co-authored-by: api-clients-generation-pipeline[bot] <54105614+api-clients-generation-pipeline[bot]@users.noreply.github.com>
1 parent a9d9835 commit 4693934

5 files changed

+10
-10
lines changed

.apigentools-info

+4-4
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@
44
"spec_versions": {
55
"v1": {
66
"apigentools_version": "1.6.6",
7-
"regenerated": "2024-09-04 14:47:52.517444",
8-
"spec_repo_commit": "b31c228b"
7+
"regenerated": "2024-09-04 15:23:38.044155",
8+
"spec_repo_commit": "fe4f848e"
99
},
1010
"v2": {
1111
"apigentools_version": "1.6.6",
12-
"regenerated": "2024-09-04 14:47:52.534363",
13-
"spec_repo_commit": "b31c228b"
12+
"regenerated": "2024-09-04 15:23:38.061137",
13+
"spec_repo_commit": "fe4f848e"
1414
}
1515
}
1616
}

examples/v2/security-monitoring/CreateSecurityMonitoringRule_3367706049.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
options=SecurityMonitoringRuleOptions(
4646
detection_method=SecurityMonitoringRuleDetectionMethod.THIRD_PARTY,
4747
keep_alive=SecurityMonitoringRuleKeepAlive.ZERO_MINUTES,
48-
max_signal_duration=SecurityMonitoringRuleMaxSignalDuration.ZERO_MINUTES,
48+
max_signal_duration=SecurityMonitoringRuleMaxSignalDuration.TEN_MINUTES,
4949
third_party_rule_options=SecurityMonitoringRuleThirdPartyOptions(
5050
default_status=SecurityMonitoringRuleSeverity.INFO,
5151
root_queries=[
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2024-05-10T16:34:29.476Z
1+
2024-09-04T13:32:10.858Z

tests/v2/cassettes/test_scenarios/test_create_a_detection_rule_with_detection_method_third_party_returns_ok_response.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
interactions:
22
- request:
3-
body: '{"cases":[],"isEnabled":true,"message":"This is a third party rule","name":"Test-Create_a_detection_rule_with_detection_method_third_party_returns_OK_response-1715358869","options":{"detectionMethod":"third_party","keepAlive":0,"maxSignalDuration":0,"thirdPartyRuleOptions":{"defaultStatus":"info","rootQueries":[{"groupByFields":["instance-id"],"query":"source:guardduty
3+
body: '{"cases":[],"isEnabled":true,"message":"This is a third party rule","name":"Test-Create_a_detection_rule_with_detection_method_third_party_returns_OK_response-1725456730","options":{"detectionMethod":"third_party","keepAlive":0,"maxSignalDuration":600,"thirdPartyRuleOptions":{"defaultStatus":"info","rootQueries":[{"groupByFields":["instance-id"],"query":"source:guardduty
44
@details.alertType:*EC2*"},{"groupByFields":[],"query":"source:guardduty"}]}},"queries":[],"thirdPartyCases":[{"name":"high","query":"status:error","status":"high"},{"name":"low","query":"status:info","status":"low"}],"type":"log_detection"}'
55
headers:
66
accept:
@@ -11,7 +11,7 @@ interactions:
1111
uri: https://api.datadoghq.com/api/v2/security_monitoring/rules
1212
response:
1313
body:
14-
string: '{"id":"uys-ie9-xgd","version":1,"name":"Test-Create_a_detection_rule_with_detection_method_third_party_returns_OK_response-1715358869","createdAt":1715358869757,"creationAuthorId":1445416,"isDefault":false,"isPartner":false,"isEnabled":true,"isDeleted":false,"isDeprecated":false,"queries":[{"query":"status:error","groupByFields":[],"hasOptionalGroupByFields":false,"distinctFields":[],"aggregation":"none","name":""},{"query":"status:info","groupByFields":[],"hasOptionalGroupByFields":false,"distinctFields":[],"aggregation":"none","name":""}],"options":{"keepAlive":0,"maxSignalDuration":0,"detectionMethod":"third_party","evaluationWindow":0,"thirdPartyRuleOptions":{"defaultStatus":"info","defaultNotifications":[],"rootQueries":[{"query":"source:guardduty
14+
string: '{"id":"rvf-kfc-pxh","version":1,"name":"Test-Create_a_detection_rule_with_detection_method_third_party_returns_OK_response-1725456730","createdAt":1725456731210,"creationAuthorId":1445416,"isDefault":false,"isPartner":false,"isEnabled":true,"isBeta":false,"isDeleted":false,"isDeprecated":false,"queries":[{"query":"status:error","groupByFields":[],"hasOptionalGroupByFields":false,"distinctFields":[],"aggregation":"none","name":""},{"query":"status:info","groupByFields":[],"hasOptionalGroupByFields":false,"distinctFields":[],"aggregation":"none","name":""}],"options":{"keepAlive":0,"maxSignalDuration":600,"detectionMethod":"third_party","evaluationWindow":0,"thirdPartyRuleOptions":{"defaultStatus":"info","defaultNotifications":[],"rootQueries":[{"query":"source:guardduty
1515
@details.alertType:*EC2*","groupByFields":["instance-id"]},{"query":"source:guardduty","groupByFields":[]}]}},"cases":[{"name":"high","status":"high","notifications":[]},{"name":"low","status":"low","notifications":[]}],"message":"This
1616
is a third party rule","tags":[],"hasExtendedTitle":false,"type":"log_detection","filters":[],"thirdPartyCases":[{"name":"high","status":"high","notifications":[],"query":"status:error"},{"name":"low","status":"low","notifications":[],"query":"status:info"}]}
1717
@@ -28,7 +28,7 @@ interactions:
2828
accept:
2929
- '*/*'
3030
method: DELETE
31-
uri: https://api.datadoghq.com/api/v2/security_monitoring/rules/uys-ie9-xgd
31+
uri: https://api.datadoghq.com/api/v2/security_monitoring/rules/rvf-kfc-pxh
3232
response:
3333
body:
3434
string: ''

tests/v2/features/security_monitoring.feature

+1-1
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ Feature: Security Monitoring
133133
@team:DataDog/k9-cloud-security-platform
134134
Scenario: Create a detection rule with detection method 'third_party' returns "OK" response
135135
Given new "CreateSecurityMonitoringRule" request
136-
And body with value {"name":"{{ unique }}","type":"log_detection","isEnabled":true,"thirdPartyCases":[{"query":"status:error","name":"high","status":"high"},{"query":"status:info","name":"low","status":"low"}],"queries":[],"cases":[],"message":"This is a third party rule","options":{"detectionMethod":"third_party","keepAlive":0,"maxSignalDuration":0,"thirdPartyRuleOptions":{"defaultStatus":"info","rootQueries":[{"query":"source:guardduty @details.alertType:*EC2*", "groupByFields":["instance-id"]},{"query":"source:guardduty", "groupByFields":[]}]}}}
136+
And body with value {"name":"{{ unique }}","type":"log_detection","isEnabled":true,"thirdPartyCases":[{"query":"status:error","name":"high","status":"high"},{"query":"status:info","name":"low","status":"low"}],"queries":[],"cases":[],"message":"This is a third party rule","options":{"detectionMethod":"third_party","keepAlive":0,"maxSignalDuration":600,"thirdPartyRuleOptions":{"defaultStatus":"info","rootQueries":[{"query":"source:guardduty @details.alertType:*EC2*", "groupByFields":["instance-id"]},{"query":"source:guardduty", "groupByFields":[]}]}}}
137137
When the request is sent
138138
Then the response status is 200 OK
139139
And the response "name" is equal to "{{ unique }}"

0 commit comments

Comments
 (0)