Skip to content

Cannot create DomainRecord entities #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nosilver4u opened this issue Mar 24, 2025 · 1 comment · Fixed by #342
Closed

Cannot create DomainRecord entities #340

nosilver4u opened this issue Mar 24, 2025 · 1 comment · Fixed by #342

Comments

@nosilver4u
Copy link

With version 5.0.3 we can no longer work with DNS CNAME records. Creating records or retrieving records both fail with this error:
PHP Fatal error: Uncaught TypeError: Cannot assign null to property DigitalOceanV2\Entity\DomainRecord::$priority of type int in .../vendor/toin0u/digitalocean-v2/src/Entity/AbstractEntity.php:62

From a quick glance at the code, I believe this same error would occur for A, AAAA, CNAME, TXT, NS, and CAA records, since none of them have a priority.
mykemeynell added a commit to mykemeynell/Client that referenced this issue Apr 29, 2025
@mykemeynell
Allow nullable properties in DomainRecord.php
dc15c1a 
Nullable properties on DomainRecord entity as returned from DigitalOcean API. Fixes DigitalOceanPHP#340
@mykemeynell mykemeynell mentioned this issue Apr 29, 2025
Merged
GrahamCampbell pushed a commit that referenced this issue Apr 30, 2025
@mykemeynell
Allow nullable properties in DomainRecord.php (#342)
56f6cdb 
Nullable properties on DomainRecord entity as returned from DigitalOcean API. Fixes #340
@nosilver4u
Copy link
Author

Thanks @mykemeynell and @GrahamCampbell !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[5.0] Allow nullable properties in DomainRecord mykemeynell/Client
1 participant
@nosilver4u