Skip to content

Commit b52f242

Browse files
authored
Merge pull request #2817 from vhatsura/version-alignment
use NuGetVersion as a value for Version attribute in project file
2 parents ac9bc4f + 0157e7a commit b52f242

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

docs/input/docs/usage/msbuild.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -189,10 +189,10 @@ have the ability to create NuGet packages directly by using the `pack` target:
189189
`msbuild /t:pack`. The version is controlled by the MSBuild properties described
190190
above.
191191

192-
GitVersionTask has the option to generate SemVer 2.0 compliant NuGet package
193-
versions by setting `UseFullSemVerForNuGet` to true in your project (this is off
194-
by default for compatibility). Some hosts, like MyGet, support SemVer 2.0
195-
package versions but older NuGet clients and nuget.org do not.
192+
GitVersionTask generates SemVer 2.0 compliant NuGet package versions by default.
193+
You can disable it by setting `UseFullSemVerForNuGet` to false in your project.
194+
Older NuGet clients do not support SemVer 2.0 package versions, but most of the
195+
modern hosts support it.
196196

197197
#### Accessing variables in MSBuild
198198

src/GitVersion.Core/VersionConverters/AssemblyInfo/ProjectFileUpdater.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public void Execute(VersionVariables variables, AssemblyInfoContext context)
4242
var assemblyVersion = variables.AssemblySemVer;
4343
var assemblyInfoVersion = variables.InformationalVersion;
4444
var assemblyFileVersion = variables.AssemblySemFileVer;
45-
var packageVersion = variables.NuGetVersionV2;
45+
var packageVersion = variables.NuGetVersion;
4646

4747
foreach (var projectFile in projectFilesToUpdate)
4848
{

src/GitVersion.MsBuild/msbuild/tools/GitVersion.MsBuild.targets

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
</GetVersion>
5353

5454
<PropertyGroup Condition=" '$(UpdateVersionProperties)' == 'true' ">
55-
<Version>$(GitVersion_FullSemVer)</Version>
55+
<Version>$(GitVersion_NuGetVersion)</Version>
5656
<VersionPrefix>$(GitVersion_MajorMinorPatch)</VersionPrefix>
5757
<VersionSuffix Condition=" '$(UseFullSemVerForNuGet)' == 'false' ">$(GitVersion_NuGetPreReleaseTag)</VersionSuffix>
5858
<VersionSuffix Condition=" '$(UseFullSemVerForNuGet)' == 'true' ">$(GitVersion_PreReleaseTag)</VersionSuffix>

0 commit comments

Comments
 (0)