Skip to content

Commit edac8f4

Browse files
committed
make Usleep constructor private
1 parent cacd8e0 commit edac8f4

File tree

5 files changed

+12
-6
lines changed

5 files changed

+12
-6
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,4 @@
99
- Requires `innmind/immutable:~5.12`
1010
- `Innmind\TimeWarp\Halt` return an `Innmind\Immutable\Attempt<Innmind\Immutable\SideEffect>`
1111
- `Innmind\TimeWarp\PeriodToMilliseconds` is now internal
12+
- `Innmind\TimeWarp\Halt\Usleep` constructor is now private, use `::new()` named constructor

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ function yourApp(Halt $halt): void
3030
// do some more
3131
}
3232

33-
yourApp(new Usleep);
33+
yourApp(Usleep::new());
3434
```
3535

3636
This example will halt your program for 42 minutes.

proofs/logger.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
'Logger interface',
1616
static fn($assert) => $assert
1717
->object(Logger::psr(
18-
new Usleep,
18+
Usleep::new(),
1919
new NullLogger,
2020
))
2121
->instance(Halt::class),
@@ -25,7 +25,7 @@
2525
'Logger',
2626
static fn($assert) => $assert
2727
->object(
28-
Logger::psr(new Usleep, new NullLogger)(
28+
Logger::psr(Usleep::new(), new NullLogger)(
2929
Period::millisecond(100),
3030
)->unwrap(),
3131
)

proofs/usleep.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
yield test(
1313
'Usleep interface',
1414
static fn($assert) => $assert
15-
->object(new Usleep)
15+
->object(Usleep::new())
1616
->instance(Halt::class),
1717
);
1818

@@ -22,7 +22,7 @@
2222
->time(static function() use ($assert) {
2323
$assert
2424
->object(
25-
(new Usleep)(Period::millisecond(500))->unwrap(),
25+
Usleep::new()(Period::millisecond(500))->unwrap(),
2626
)
2727
->instance(SideEffect::class);
2828
})

src/Halt/Usleep.php

+6-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ final class Usleep implements Halt
1717
{
1818
private PeriodToMilliseconds $periodToMilliseconds;
1919

20-
public function __construct()
20+
private function __construct()
2121
{
2222
$this->periodToMilliseconds = new PeriodToMilliseconds;
2323
}
@@ -30,4 +30,9 @@ public function __invoke(Period $period): Attempt
3030

3131
return Attempt::result(SideEffect::identity());
3232
}
33+
34+
public static function new(): self
35+
{
36+
return new self;
37+
}
3338
}

0 commit comments

Comments
 (0)