Skip to content

Commit 316240c

Browse files
vtavanaantonwolfy
andauthored
remove einsum_call kwargs from dpnp.einsum_path signature (#2421)
`einsum_call` is a [hidden kwarg](https://github.com/numpy/numpy/blob/main/numpy/_core/einsumfunc.pyi#L174). In NumPy, it has been used internally inside `einsum` but it is not needed in dpnp so removing it from the signature. --------- Co-authored-by: Anton <[email protected]>
1 parent 5468479 commit 316240c

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ This release achieves 100% compliance with Python Array API specification (revis
2626
* Updated `dpnp.fix` to return output with the same data-type of input [#2392](https://github.com/IntelPython/dpnp/pull/2392)
2727
* Updated `dpnp.einsum` to add support for `order=None` [#2411](https://github.com/IntelPython/dpnp/pull/2411)
2828
* Updated Python Array API specification version supported to `2024.12` [#2416](https://github.com/IntelPython/dpnp/pull/2416)
29+
* Removed `einsum_call` keyword from `dpnp.einsum_path` signature [#2421](https://github.com/IntelPython/dpnp/pull/2421)
2930

3031
### Fixed
3132

dpnp/dpnp_iface_linearalgebra.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -457,7 +457,7 @@ def einsum(
457457
)
458458

459459

460-
def einsum_path(*operands, optimize="greedy", einsum_call=False):
460+
def einsum_path(*operands, optimize="greedy"):
461461
"""
462462
einsum_path(subscripts, *operands, optimize="greedy")
463463
@@ -483,7 +483,7 @@ def einsum_path(*operands, optimize="greedy", einsum_call=False):
483483
* if a list is given that starts with ``einsum_path``, uses this as the
484484
contraction path
485485
* if ``False`` or ``None`` no optimization is taken
486-
* if ``True`` defaults to the "greedy" algorithm
486+
* if ``True`` defaults to the ``"greedy"`` algorithm
487487
* ``"optimal"`` is an algorithm that combinatorially explores all
488488
possible ways of contracting the listed tensors and chooses the
489489
least costly path. Scales exponentially with the number of terms
@@ -586,7 +586,7 @@ def einsum_path(*operands, optimize="greedy", einsum_call=False):
586586
return numpy.einsum_path(
587587
*operands,
588588
optimize=optimize,
589-
einsum_call=einsum_call,
589+
einsum_call=False,
590590
)
591591

592592

0 commit comments

Comments
 (0)