Skip to content

Add LBE #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Add LBE #18

merged 2 commits into from
Jan 7, 2025

Conversation

Yuan-Ru-Lin
Copy link
Member

This PR add a physics list, LBE to the list of classes to be wrapped.

After installing WrapIt! by following this tutorial, I confirm the physics list can be assigned to be physics_type of a G4JLApplication, which runs without error.

Some methods in gen/jlGeant4-report.txt are removed. Maybe @peremato you should take a look at it.

I'm willing to work on upgrading Geant_cxxwrap and then regenerating Geant4_julia_jll but I need some instruction for I'm not really familiar with BinaryBuilder.

No idea why some methods are removed
@Yuan-Ru-Lin Yuan-Ru-Lin requested a review from peremato January 5, 2025 06:35
Copy link
Member

@peremato peremato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem for adding LBE physics list. The issue with the missing methods (as seen on the jlGeant4-report.txt file is because the installation of WrapIt used by WrapIt.jll is build with clang17 and it has a problem detecting the type size_t. All methods with site_t has been ignored.

@peremato
Copy link
Member

peremato commented Jan 7, 2025

I'll crate a new version of Geant4_julia_jll with the changes ASAP.

@peremato peremato merged commit bd199c7 into JuliaHEP:master Jan 7, 2025
4 checks passed
@Yuan-Ru-Lin
Copy link
Member Author

I'll crate a new version of Geant4_julia_jll with the changes ASAP.

Thanks!

The issue with the missing methods (as seen on the jlGeant4-report.txt file is because the installation of WrapIt used by WrapIt.jll is build with clang17 and it has a problem detecting the type size_t. All methods with site_t has been ignored.

It seems to be a problem. For example,

-size_t G4LogicalVolume::GetNoDaughters()
-G4VPhysicalVolume * G4LogicalVolume::GetDaughter(const size_t)

these two methods are used in the package.

Also, I wonder how the methods were compiled before, since they exist in the shared library that master is using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants