Skip to content

Commit d1ab622

Browse files
committed
move ImageShow to make.jl and add missing docs dependency
When building documentation locally we need to manually do `]dev .` to tell Julia use dev version of MLDatasets, and this immediately updates the Project.toml file, to keep it complete I commit this change . This change won't affect docs CI.
1 parent 5203e3d commit d1ab622

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

docs/Project.toml

+1
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,4 @@ Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4"
33
ImageCore = "a09fc81d-aa75-5fe9-8630-4744c3626534"
44
ImageIO = "82e4d734-157c-48bb-816b-45c225c6df19"
55
ImageShow = "4e3cecfd-b093-5904-9786-8bbb286a6a31"
6+
MLDatasets = "eb30cadb-4394-5ae3-aed4-317e484a6458"

docs/make.jl

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
using Documenter, MLDatasets
2+
using ImageShow # for better image display
23

34
## Commented out since gives warning
45
# DocMeta.setdocmeta!(MLDatasets, :DocTestSetup, :(using MLDatasets); recursive=true)
@@ -34,7 +35,7 @@ makedocs(
3435
"Iris" => "datasets/Iris.md",
3536
"Boston Housing" => "datasets/BostonHousing.md",
3637
],
37-
38+
3839
"Text" => Any[
3940
"PTBLM" => "datasets/PTBLM.md",
4041
"UD_English" => "datasets/UD_English.md",
@@ -54,4 +55,4 @@ makedocs(
5455
)
5556

5657

57-
deploydocs(repo = "github.com/JuliaML/MLDatasets.jl.git")
58+
deploydocs(repo = "github.com/JuliaML/MLDatasets.jl.git")

docs/src/index.md

+3-5
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,10 @@ of images.
6363

6464
```@example
6565
using MLDatasets
66-
# Alternatively, you can also just call `using Images`
67-
using ImageCore, ImageShow
66+
using ImageCore
6867
69-
# The original dataset is stored in row-major order,
70-
# to display it normally in Julia, we need to permute the
71-
# first two dimensions.
68+
# The original dataset is stored in row-major order, to display it
69+
# normally in Julia, we need to permute the first two dimensions.
7270
test_x = Gray.(PermutedDimsArray(MNIST.testtensor(), (2, 1, 3)));
7371
test_x_sample = @view test_x[:, :, 1:64];
7472

0 commit comments

Comments
 (0)