Skip to content

Commit 938522d

Browse files
authored
Merge pull request #3 from findmyway/fix_fig_13_2
modify params in chapter13/short_corridor.jl
2 parents 5caf99d + fac5b08 commit 938522d

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ If you would like to make some improvements, I'd suggest the following workflow:
6868
| | [fig_10_3](https://raw.githubusercontent.com/Ju-jl/ReinforcementLearningAnIntroduction.jl/master/docs/src/assets/figures/figure_10_3.png), [fig_10_4](https://raw.githubusercontent.com/Ju-jl/ReinforcementLearningAnIntroduction.jl/master/docs/src/assets/figures/figure_10_4.png), [fig_10_5](https://raw.githubusercontent.com/Ju-jl/ReinforcementLearningAnIntroduction.jl/master/docs/src/assets/figures/figure_10_5.png)| |
6969
|Chapter11 | [fig_11_2](https://raw.githubusercontent.com/Ju-jl/ReinforcementLearningAnIntroduction.jl/master/docs/src/assets/figures/figure_11_2.png) | |
7070
|Chapter12 | [fig_12_3](https://raw.githubusercontent.com/Ju-jl/ReinforcementLearningAnIntroduction.jl/master/docs/src/assets/figures/figure_12_3.png)| Other figures in Chapter12 are not that easy to reproduce by using the Ju.jl package. You may take a try and correct me with a PR.|
71-
| Chapter13 | [fig_13_1](https://raw.githubusercontent.com/Ju-jl/ReinforcementLearningAnIntroduction.jl/master/docs/src/assets/figures/figure_13_1.png), [fig_13_2](https://raw.githubusercontent.com/Ju-jl/ReinforcementLearningAnIntroduction.jl/master/docs/src/assets/figures/figure_13_2.png) | Figure_13_2 is a slightly different to the original figure on the book.|
71+
| Chapter13 | [fig_13_1](https://raw.githubusercontent.com/Ju-jl/ReinforcementLearningAnIntroduction.jl/master/docs/src/assets/figures/figure_13_1.png), [fig_13_2](https://raw.githubusercontent.com/Ju-jl/ReinforcementLearningAnIntroduction.jl/master/docs/src/assets/figures/figure_13_2.png) | ~~Figure_13_2 is a slightly different to the original figure on the book.~~ Thanks to Eric Graves's clarification, fixed in [#3](https://github.com/Ju-jl/ReinforcementLearningAnIntroduction.jl/pull/3)|
7272

7373
# Related Packages
7474

3.43 KB
Loading

src/chapter13/short_corridor.jl

+3-3
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ function run_once_RL()
2828
features[i, :, :] .= [0 1; 1 0]
2929
end
3030
agent = Agent(ReinforceLearner(LinearPolicy(features, [-1.47, 1.47]),
31-
2e-4,
31+
2^-13,
3232
1.),
3333
EpisodeSARDBuffer())
3434
callbacks = (stop_at_episode(1000, false), rewards_of_each_episode())
@@ -56,8 +56,8 @@ function run_once_RLBaseline()
5656
end
5757
agent = Agent(ReinforceBaselineLearner(TabularV(zeros(length(observationspace(env)))),
5858
LinearPolicy(features, [-1.47, 1.47]),
59-
1e-4,
60-
1e-4,
59+
2^-6,
60+
2^-9,
6161
1.),
6262
EpisodeSARDBuffer())
6363
callbacks = (stop_at_episode(1000, false), rewards_of_each_episode())

0 commit comments

Comments
 (0)