Skip to content

New dummy CAD repo and matching e2e tests #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pierremtb opened this issue May 8, 2023 · 7 comments · Fixed by #149
Closed

New dummy CAD repo and matching e2e tests #141

pierremtb opened this issue May 8, 2023 · 7 comments · Fixed by #149
Assignees
Labels
systems Systems things

Comments

@pierremtb
Copy link
Collaborator

Right now the tests are pointing to somewhat random changes on other repos assets here, like https://github.com/KittyCAD/kittycad.ts/pull/3/files where the .obj file is only added, not modified. My manual testing when developing often takes place on https://github.com/pierremtb/SwStpGitExample, an old repo I had created for myself 2y ago.

I think we should create a new one in the KittyCAD org, with dummy "real cad use" commits and PRs. And update the e2e tests to point to it

@org-projects-app
Copy link

org-projects-app[bot] added this issue to KittyCode Project.

@pierremtb pierremtb added the systems Systems things label May 8, 2023
@org-projects-app
Copy link

pierremtb added this issue to 2023 Q2 - Ends June 30th.
And I (the bot) will remove the issue from KittyCode, (issues shouldn't be in the backlog if they're in another project)

@org-projects-app
Copy link

org-projects-app[bot] removed this issue from KittyCode Project.

@pierremtb pierremtb self-assigned this May 8, 2023
@pierremtb
Copy link
Collaborator Author

Started https://github.com/KittyCAD/diff-samples as a private repo, but I think it could be turned into public without issues.

KittyCAD/diff-samples#1

KittyCAD/diff-samples#2

@pierremtb
Copy link
Collaborator Author

@jessfraz Let me know if you think https://github.com/KittyCAD/diff-samples could be made Public. I would then be able to have my e2e tests run against it (they have API tokens but signing in the browser is trickier)

@jessfraz
Copy link

jessfraz commented May 9, 2023

oh go for it!

@pierremtb
Copy link
Collaborator Author

oh go for it!

Done! Thank you @jessfraz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
systems Systems things
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants