Skip to content

[Improvement] Include the storage/hot file in pruning prior to build (Perhaps user-defined excludes too) #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PeteBishwhip opened this issue Mar 7, 2025 · 0 comments
Assignees

Comments

@PeteBishwhip
Copy link
Member

PeteBishwhip commented Mar 7, 2025

Improvement

It's sometimes possible that the storage/hot file could be present whilst running native:build. Although it shouldn't be, we're aware of some instances where it may not have been removed successfully or the process ended before it could be removed.

This ticket is just to see the pruning updated to include the hot file.

Relevant code: https://github.com/NativePHP/electron/blob/main/src/Traits/CopiesToBuildDirectory.php#L26

Perhaps we could also improve this by either adding a config option or a .nativeignore file for developers to specify other files that may wish to be excluded from build.

@PeteBishwhip PeteBishwhip added bug Something isn't working and removed bug Something isn't working labels Mar 7, 2025
@PeteBishwhip PeteBishwhip self-assigned this Mar 7, 2025
@PeteBishwhip PeteBishwhip changed the title [Improvement] Include the storage/hot file in pruning prior to build [Improvement] Include the storage/hot file in pruning prior to build (Perhaps user-defined excludes too) Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant