From cf50a0a6d252f3a5ec6a05f65cbd9eb51db44da9 Mon Sep 17 00:00:00 2001 From: Pete Bishop Date: Wed, 19 Mar 2025 11:22:27 +0000 Subject: [PATCH 1/6] Pin to v2.5.0 --- .github/workflows/build-php.yml | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build-php.yml b/.github/workflows/build-php.yml index 4385f0ca..53ea6917 100644 --- a/.github/workflows/build-php.yml +++ b/.github/workflows/build-php.yml @@ -35,35 +35,40 @@ jobs: - name: Set SPC URL for macos-13 shell: bash if: matrix.os == 'macos-13' - run: echo "SPC_URL=https://dl.static-php.dev/static-php-cli/spc-bin/nightly/spc-macos-x86_64" >> $GITHUB_ENV + run: echo "SPC_URL=https://github.com/crazywhalecc/static-php-cli/releases/download/2.5.0/spc-macos-x86_64.tar.gz" >> $GITHUB_ENV - name: Set SPC URL for macos-latest shell: bash if: matrix.os == 'macos-latest' - run: echo "SPC_URL=https://dl.static-php.dev/static-php-cli/spc-bin/nightly/spc-macos-aarch64" >> $GITHUB_ENV + run: echo "SPC_URL=https://github.com/crazywhalecc/static-php-cli/releases/download/2.5.0/spc-macos-aarch64.tar.gz" >> $GITHUB_ENV - name: Set SPC URL for ubuntu-latest and ubuntu-24.04 shell: bash if: matrix.os == 'ubuntu-latest' - run: echo "SPC_URL=https://dl.static-php.dev/static-php-cli/spc-bin/nightly/spc-linux-x86_64" >> $GITHUB_ENV + run: echo "SPC_URL=https://github.com/crazywhalecc/static-php-cli/releases/download/2.5.0/spc-linux-x86_64.tar.gz" >> $GITHUB_ENV - name: Set SPC URL for ubuntu-24.04-arm shell: bash if: matrix.os == 'ubuntu-24.04-arm' - run: echo "SPC_URL=https://dl.static-php.dev/static-php-cli/spc-bin/nightly/spc-linux-aarch64" >> $GITHUB_ENV + run: echo "SPC_URL=https://github.com/crazywhalecc/static-php-cli/releases/download/2.5.0/spc-linux-aarch64.tar.gz" >> $GITHUB_ENV - name: Set SPC URL for windows-latest shell: bash if: matrix.os == 'windows-latest' run: | - echo "SPC_URL=https://dl.static-php.dev/static-php-cli/spc-bin/nightly/spc-windows-x64.exe" >> $GITHUB_ENV + echo "SPC_URL=https://github.com/crazywhalecc/static-php-cli/releases/download/2.5.0/spc-windows-x64.exe" >> $GITHUB_ENV echo "SPC_BINARY=spc.exe" >> $GITHUB_ENV - name: Download SPC shell: bash run: | cd .. - curl -fsSL -o ${{ env.SPC_BINARY }} ${{ env.SPC_URL }} + if [[ "${{ matrix.os }}" == "windows-latest" ]]; then + curl -fsSL -o ${{ env.SPC_BINARY }} ${{ env.SPC_URL }} + else + curl -fsSL -o ${{ env.SPC_BINARY }}.tar.gz ${{ env.SPC_URL }} + tar -xzf ${{ env.SPC_BINARY }}.tar.gz + fi chmod +x ${{ env.SPC_BINARY }} [ ! -d static-php-cli/bin ] && mkdir -p static-php-cli/bin mv ${{ env.SPC_BINARY }} static-php-cli/bin/ From 676615df69d241572191f30d1ed7606fb1d0ba19 Mon Sep 17 00:00:00 2001 From: Pete Bishop Date: Wed, 19 Mar 2025 11:29:32 +0000 Subject: [PATCH 2/6] Version as an env var for easy update --- .github/workflows/build-php.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build-php.yml b/.github/workflows/build-php.yml index 53ea6917..451423a3 100644 --- a/.github/workflows/build-php.yml +++ b/.github/workflows/build-php.yml @@ -12,6 +12,7 @@ on: env: GITHUB_TOKEN: ${{ secrets.PAT }} + SPC_VERSION: 2.5.0 jobs: build: @@ -35,28 +36,28 @@ jobs: - name: Set SPC URL for macos-13 shell: bash if: matrix.os == 'macos-13' - run: echo "SPC_URL=https://github.com/crazywhalecc/static-php-cli/releases/download/2.5.0/spc-macos-x86_64.tar.gz" >> $GITHUB_ENV + run: echo "SPC_URL=https://github.com/crazywhalecc/static-php-cli/releases/download/${{ env.SPC_VERSION }}/spc-macos-x86_64.tar.gz" >> $GITHUB_ENV - name: Set SPC URL for macos-latest shell: bash if: matrix.os == 'macos-latest' - run: echo "SPC_URL=https://github.com/crazywhalecc/static-php-cli/releases/download/2.5.0/spc-macos-aarch64.tar.gz" >> $GITHUB_ENV + run: echo "SPC_URL=https://github.com/crazywhalecc/static-php-cli/releases/download/${{ env.SPC_VERSION }}/spc-macos-aarch64.tar.gz" >> $GITHUB_ENV - name: Set SPC URL for ubuntu-latest and ubuntu-24.04 shell: bash if: matrix.os == 'ubuntu-latest' - run: echo "SPC_URL=https://github.com/crazywhalecc/static-php-cli/releases/download/2.5.0/spc-linux-x86_64.tar.gz" >> $GITHUB_ENV + run: echo "SPC_URL=https://github.com/crazywhalecc/static-php-cli/releases/download/${{ env.SPC_VERSION }}/spc-linux-x86_64.tar.gz" >> $GITHUB_ENV - name: Set SPC URL for ubuntu-24.04-arm shell: bash if: matrix.os == 'ubuntu-24.04-arm' - run: echo "SPC_URL=https://github.com/crazywhalecc/static-php-cli/releases/download/2.5.0/spc-linux-aarch64.tar.gz" >> $GITHUB_ENV + run: echo "SPC_URL=https://github.com/crazywhalecc/static-php-cli/releases/download/${{ env.SPC_VERSION }}/spc-linux-aarch64.tar.gz" >> $GITHUB_ENV - name: Set SPC URL for windows-latest shell: bash if: matrix.os == 'windows-latest' run: | - echo "SPC_URL=https://github.com/crazywhalecc/static-php-cli/releases/download/2.5.0/spc-windows-x64.exe" >> $GITHUB_ENV + echo "SPC_URL=https://github.com/crazywhalecc/static-php-cli/releases/download/${{ env.SPC_VERSION }}/spc-windows-x64.exe" >> $GITHUB_ENV echo "SPC_BINARY=spc.exe" >> $GITHUB_ENV - name: Download SPC From 8f86638e29d118066f03448fddb833838eb4c6a4 Mon Sep 17 00:00:00 2001 From: Pete Bishop Date: Wed, 19 Mar 2025 11:45:20 +0000 Subject: [PATCH 3/6] Add debug flag --- .github/workflows/build-php.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-php.yml b/.github/workflows/build-php.yml index 451423a3..882ac63b 100644 --- a/.github/workflows/build-php.yml +++ b/.github/workflows/build-php.yml @@ -155,7 +155,7 @@ jobs: - name: Build PHP run: | cd ../static-php-cli - ./bin/${{ env.SPC_BINARY }} build --build-cli "${{ env.PHP_EXTENSIONS }}" --with-libs="${{ env.PHP_LIBS }}" + ./bin/${{ env.SPC_BINARY }} build --build-cli "${{ env.PHP_EXTENSIONS }}" --with-libs="${{ env.PHP_LIBS }}" --debug cd ../php-bin - name: Get built PHP version From 3c563c8504d984d72d5d522efb1ce3c79f2ca821 Mon Sep 17 00:00:00 2001 From: Pete Bishop Date: Wed, 19 Mar 2025 13:14:34 +0000 Subject: [PATCH 4/6] Downgrade SPC to 2.4.5 --- .github/workflows/build-php.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-php.yml b/.github/workflows/build-php.yml index 882ac63b..df589e19 100644 --- a/.github/workflows/build-php.yml +++ b/.github/workflows/build-php.yml @@ -12,7 +12,7 @@ on: env: GITHUB_TOKEN: ${{ secrets.PAT }} - SPC_VERSION: 2.5.0 + SPC_VERSION: 2.4.5 jobs: build: From 31c970712a3ff34056875a720b1c2b42ff4820b2 Mon Sep 17 00:00:00 2001 From: Pete Bishop Date: Wed, 19 Mar 2025 13:54:23 +0000 Subject: [PATCH 5/6] Downgrade SPC to 2.4.4 --- .github/workflows/build-php.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-php.yml b/.github/workflows/build-php.yml index df589e19..daa09820 100644 --- a/.github/workflows/build-php.yml +++ b/.github/workflows/build-php.yml @@ -12,7 +12,7 @@ on: env: GITHUB_TOKEN: ${{ secrets.PAT }} - SPC_VERSION: 2.4.5 + SPC_VERSION: 2.4.4 jobs: build: From 3e0132c79e0c73375c77aed36cba627705170749 Mon Sep 17 00:00:00 2001 From: Pete Bishop Date: Wed, 19 Mar 2025 14:01:20 +0000 Subject: [PATCH 6/6] WINBUILD_ACKNOWLEDGE_DEPRECATED flag --- .github/workflows/build-php.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/build-php.yml b/.github/workflows/build-php.yml index daa09820..a3fce189 100644 --- a/.github/workflows/build-php.yml +++ b/.github/workflows/build-php.yml @@ -13,6 +13,9 @@ on: env: GITHUB_TOKEN: ${{ secrets.PAT }} SPC_VERSION: 2.4.4 + # Temporary workaround. See https://github.com/NativePHP/laravel/issues/522#issuecomment-2736250539 + # Remove when updating SPC version + WINBUILD_ACKNOWLEDGE_DEPRECATED: yes jobs: build: