Skip to content

Commit 8e2d1f0

Browse files
author
Dirk Eismann
authored
fix: use (anonymous) for empty functionNames when generating stack information (#66)
closes #65
1 parent 7523b2f commit 8e2d1f0

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

packages/firebase-crashlytics/index.android.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ export class Crashlytics implements ICrashlytics {
7373
StackTrace.fromError(error).then((stack) => {
7474
const traceElements = Array.create('java.lang.StackTraceElement', stack.length);
7575
stack.forEach((item, i) => {
76-
traceElements[i] = new java.lang.StackTraceElement('', item.functionName, item.fileName, -1);
76+
traceElements[i] = new java.lang.StackTraceElement('', item.functionName || '(anonymous)', item.fileName, -1);
7777
});
7878
const t = new java.lang.Throwable(error.message);
7979
t.setStackTrace(traceElements);

packages/firebase-crashlytics/index.ios.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ export class Crashlytics implements ICrashlytics {
6767
StackTrace.fromError(error).then((stack) => {
6868
const traceElements = [];
6969
stack.forEach((item, i) => {
70-
traceElements[i] = FIRStackFrame.stackFrameWithSymbolFileLine(item.functionName, item.fileName, item.lineNumber);
70+
traceElements[i] = FIRStackFrame.stackFrameWithSymbolFileLine(item.functionName || '(anonymous)', item.fileName, item.lineNumber);
7171
});
7272
const e = FIRExceptionModel.exceptionModelWithNameReason('JavaScriptError', error.message);
7373
this.native.recordExceptionModel(e);

0 commit comments

Comments
 (0)