Skip to content

Match Ordered List number to Notion #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PascalPixel opened this issue Apr 13, 2024 · 1 comment · May be fixed by #627
Open

Match Ordered List number to Notion #548

PascalPixel opened this issue Apr 13, 2024 · 1 comment · May be fixed by #627

Comments

@PascalPixel
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Re-implements #437 to match the list numbers shown in Notion 🎊

Here is the diff that solved my problem:

diff --git a/node_modules/react-notion-x/build/index.js b/node_modules/react-notion-x/build/index.js
index a18bcfd..721a4cb 100644
--- a/node_modules/react-notion-x/build/index.js
+++ b/node_modules/react-notion-x/build/index.js
@@ -318,7 +318,10 @@ var getListNumber = (blockId, blockMap) => {
   if (!group) {
     return;
   }
-  return group.indexOf(blockId) + 1;
+  return (
+    blockMap[blockId].value.format?.list_start_index ||
+    group.indexOf(blockId) + 1
+  )
 };
 var getHashFragmentValue = (url) => {
   return url.includes("#") ? url.replace(/^.+(#.+)$/, "$1") : "";

This issue body was partially generated by patch-package.

@maxchan23
Copy link

Hey I'm encountering this issue too, can we please get this sorted ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants