Skip to content

Commit f5498a6

Browse files
authored
Merge pull request #143 from ODM2/samplingfeaturedataset_dev
Samplingfeaturedataset dev
2 parents f634574 + 9c1a7dc commit f5498a6

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

.travis.yml

-2
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,6 @@ matrix:
3939
- python: 3.6
4040
env: TEST_TARGET=docs
4141
allow_failures:
42-
- python: 2.7
43-
env: TEST_TARGET=coding_standards
4442
- python: 3.6
4543
env: TEST_TARGET=default
4644

odm2api/ODM2/services/readService.py

+9-5
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
import pandas as pd
4040

4141
from sqlalchemy import distinct, exists
42+
from sqlalchemy.orm import contains_eager
4243

4344
__author__ = 'sreeder'
4445

@@ -81,7 +82,6 @@ class SamplingFeatureDataSet():
8182
def __init__(self, samplingfeature, datasetresults, relatedfeatures):
8283
sf = samplingfeature
8384

84-
self.SamplingFeature = sf
8585
self.SamplingFeatureID = sf.SamplingFeatureID
8686
self.SamplingFeatureUUID = sf.SamplingFeatureUUID
8787
self.SamplingFeatureTypeCV = sf.SamplingFeatureTypeCV
@@ -1020,10 +1020,14 @@ def getSamplingFeatureDatasets(self, ids=None, codes=None, uuids=None, dstype=No
10201020
sfds = []
10211021
for sf in sf_list:
10221022

1023-
q = self._session.query(DataSetsResults) \
1024-
.join(Results) \
1025-
.join(FeatureActions) \
1026-
.filter(FeatureActions.SamplingFeatureID == sf.SamplingFeatureID)
1023+
# Eager loading the data.
1024+
q = self._session.query(DataSetsResults)\
1025+
.join(DataSetsResults.ResultObj)\
1026+
.join(Results.FeatureActionObj)\
1027+
.filter(FeatureActions.SamplingFeatureID == sf.SamplingFeatureID)\
1028+
.options(contains_eager(DataSetsResults.ResultObj)
1029+
.contains_eager(Results.FeatureActionObj)
1030+
.load_only(FeatureActions.SamplingFeatureID))
10271031

10281032
if dstype:
10291033
q = q.filter_by(DatasetTypeCV=dstype)

0 commit comments

Comments
 (0)