Merge pull request #191 from tapasweni-pathak/predev

Enable Flake8

Author: tapaswenipathak

.travis.yml

@@ -22,6 +22,7 @@ before_script:
   - python manage.py collectstatic --noinput
 
 script:
+  - flake8 .
   - coverage run --source='main' manage.py test --verbosity 2
 
 after_success:

oshc/authentication/regbackend.py

@@ -3,7 +3,8 @@
 
 class EmailLoginBackend(object):
     '''
-    This class checks that the user can be authenticated via our backend and if it fails than normal authentication backend is used.
+    This class checks that the user can be authenticated via our backend and
+    if it fails than normal authentication backend is used.
     '''
 
     def authenticate(self, username=None, password=None):
@@ -15,7 +16,7 @@ def authenticate(self, username=None, password=None):
         except user_cls.DoesNotExist:
             return None
         return None
-        
+
     def get_user(self, user_id):
         user_cls = get_user_model()
         try:

oshc/authentication/urls.py

@@ -4,5 +4,6 @@
 urlpatterns = [
     url(r'^accounts/', include('allauth.urls')),
     url(r'^accounts/login/profile/', views.profile, name="profile"),
-    url(r'^ajax/validate_username/$', views.validate_username, name='validate_username'),
+    url(r'^ajax/validate_username/$', views.validate_username,
+        name='validate_username'),
 ]

oshc/authentication/views.py

@@ -12,4 +12,4 @@ def validate_username(request):
     data = {
         'is_present': User.objects.filter(username__iexact=username).exists()
     }
-    return JsonResponse(data)
+    return JsonResponse(data)

oshc/main/admin.py

@@ -11,7 +11,8 @@ class chatSessionAdmin(admin.ModelAdmin):
 
 
 class contestAdmin(admin.ModelAdmin):
-    list_display = ('name', 'link', 'description', 'start_date', 'end_date', 'approved')
+    list_display = ('name', 'link', 'description', 'start_date', 'end_date',
+                    'approved')
     actions = ['approve_contest']
 
     def approve_contest(self, request, queryset):
@@ -23,5 +24,6 @@ def approve_contest(self, request, queryset):
         self.message_user(request, "{} approved.".format(message_bit))
     approve_contest.short_description = "Approve"
 
+
 admin.site.register(chatSession, chatSessionAdmin)
 admin.site.register(Contest, contestAdmin)

oshc/main/models.py

@@ -6,7 +6,8 @@
 
 class chatSession(models.Model):
     title = models.CharField(max_length=128, help_text="Session title")
-    profile_name = models.CharField(max_length=128, help_text="The person's name")
+    profile_name = models.CharField(max_length=128,
+                                    help_text="The person's name")
     profile_url = models.URLField(help_text="The Url of the person's website")
     description = models.TextField(max_length=512, help_text="Session details")
     start_date = models.DateTimeField()

oshc/main/tests.py

@@ -1,7 +1,6 @@
 # -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
-from django.contrib.auth.models import User
 from django.test import SimpleTestCase, TestCase
 from django.urls import reverse
 

oshc/main/views.py

@@ -1,7 +1,6 @@
 from django.shortcuts import render
 from django.http import HttpResponseRedirect
 from main.models import chatSession, Contest
-from datetime import datetime
 from django.shortcuts import render_to_response
 from django.template import RequestContext
 from .forms import ContestForm
@@ -38,6 +37,7 @@ def add_contest(request):
         form = ContestForm()
     return render(request, 'contest_edit.html', {'form': form})
 
+
 def submit_contest(request):
     return render(request, 'contest_submission.html')
 

oshc/oshc/settings.py

@@ -95,16 +95,20 @@
 
 AUTH_PASSWORD_VALIDATORS = [
     {
-        'NAME': 'django.contrib.auth.password_validation.UserAttributeSimilarityValidator',
+        'NAME': 'django.contrib.auth.password_validation.'
+                'UserAttributeSimilarityValidator',
     },
     {
-        'NAME': 'django.contrib.auth.password_validation.MinimumLengthValidator',
+        'NAME': 'django.contrib.auth.password_validation.'
+                'MinimumLengthValidator',
     },
     {
-        'NAME': 'django.contrib.auth.password_validation.CommonPasswordValidator',
+        'NAME': 'django.contrib.auth.password_validation.'
+                'CommonPasswordValidator',
     },
     {
-        'NAME': 'django.contrib.auth.password_validation.NumericPasswordValidator',
+        'NAME': 'django.contrib.auth.password_validation.'
+                'NumericPasswordValidator',
     },
 ]
 

oshc/oshc/wsgi.py

@@ -8,7 +8,7 @@
 """
 
 import os
+from django.core.wsgi import get_wsgi_application
 os.environ.setdefault("DJANGO_SETTINGS_MODULE", "oshc.settings")
 
-from django.core.wsgi import get_wsgi_application
 application = get_wsgi_application()

requirements.txt

@@ -6,4 +6,5 @@ psycopg2==2.7.3.1
 pytz==2017.2
 whitenoise==3.3.1
 django-allauth==0.33.0
-django-crispy-forms==1.7.0
+django-crispy-forms==1.7.0
+flake8==3.4.1