feat: add time_zone to Datetime results
#33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows setting a time zone for datetimes and checking if the values in the column matches it
dfrankland
requested review from
borchero,
AndreasAlbertQC and
delsner
as code owners
|
Thank you for opening this pull request! 👋🏼 This repository requires pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details |
dfrankland
commented
May 7, 2025
Comment on lines
+351
to
+379
| ( | ||
| dy.Date(), | ||
| [dt.date(2020, 1, 1), dt.date(2021, 1, 15), dt.date(2022, 12, 1)], | ||
| {}, | ||
| ), | ||
| ( | ||
| dy.Date(resolution="1mo"), | ||
| [dt.date(2020, 1, 1), dt.date(2021, 1, 15), dt.date(2022, 12, 1)], | ||
| {"resolution": [True, False, True]}, | ||
| ), | ||
| ( | ||
| dy.Time(), | ||
| [dt.time(12, 0), dt.time(13, 15), dt.time(14, 0, 5)], | ||
| {}, | ||
| ), | ||
| ( | ||
| dy.Time(resolution="1h"), | ||
| [dt.time(12, 0), dt.time(13, 15), dt.time(14, 0, 5)], | ||
| {"resolution": [True, False, False]}, | ||
| ), | ||
| ( | ||
| dy.Datetime(), | ||
| [ | ||
| dt.datetime(2020, 4, 5), | ||
| dt.datetime(2021, 1, 1, 12), | ||
| dt.datetime(2022, 7, 10, 0, 0, 1), | ||
| ], | ||
| {}, | ||
| ), |
There was a problem hiding this comment.
I added these since I wanted to double-check the negative case when nothing is specified, but I'm happy to remove them if you believe these are too verbose
dfrankland
changed the title
time_zone to Datetime resultstime_zone to Datetime results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #32
Changes
allows setting a time zone for datetimes and checking if the values in the column matches it
Pertinent polars docs:
https://docs.pola.rs/user-guide/transformations/time-series/timezones/