Skip to content

Stop serving apps on herokuapp.com subdomains #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
grega opened this issue Apr 3, 2025 · 1 comment · May be fixed by #535
Open

Stop serving apps on herokuapp.com subdomains #533

grega opened this issue Apr 3, 2025 · 1 comment · May be fixed by #535
Assignees
@adrian-rpf

Comments

@grega
Copy link
Member

grega commented Apr 3, 2025 •
edited
Loading

Staging and production apps on herokuapp.com subdomains should not be accessible, but currently are:

(https://staging-editor-api.raspberrypi.org and https://editor-api.raspberrypi.org should be used instead).

The application can be configured (via config.hosts) to only respond to requests on specific (sub)domains, eg: https://github.com/RaspberryPiFoundation/experience-cs/blob/main/config/environments/production.rb#L78-L79

Note that review app URLs also need to be explicitly set in this case eg. https://github.com/RaspberryPiFoundation/experience-cs/blob/main/config/environments/production.rb#L82

Settings for this are here:

Image
@create-issue-branch Create Issue Branch
Copy link
Contributor

Branch issues/533-Stop_serving_apps_on_herokuapp_com_subdomains created!

create-issue-branch bot added a commit that referenced this issue Apr 15, 2025
@create-issue-branch
Create draft PR for #533
95f8e7c
@create-issue-branch create-issue-branch bot linked a pull request Apr 15, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adrian-rpf adrian-rpf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop serving apps on herokuapp.com subdomains RaspberryPiFoundation/editor-api
2 participants
@grega @adrian-rpf