Skip to content

Commit 6d13102

Browse files
Merge pull request #82 from SciML/needs_concrete
Add needs_concrete_A algorithm trait
2 parents c112705 + b83d548 commit 6d13102

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

Project.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "LinearSolve"
22
uuid = "7ed4a6bd-45f5-4d41-b270-4a48e9bafcae"
33
authors = ["SciML"]
4-
version = "1.1.3"
4+
version = "1.2.0"
55

66
[deps]
77
ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"

src/LinearSolve.jl

+7
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,13 @@ abstract type SciMLLinearSolveAlgorithm <: SciMLBase.AbstractLinearAlgorithm end
2727
abstract type AbstractFactorization <: SciMLLinearSolveAlgorithm end
2828
abstract type AbstractKrylovSubspaceMethod <: SciMLLinearSolveAlgorithm end
2929

30+
# Traits
31+
32+
needs_concrete_A(alg::AbstractFactorization) = true
33+
needs_concrete_A(alg::AbstractKrylovSubspaceMethod) = true
34+
35+
# Code
36+
3037
include("common.jl")
3138
include("factorization.jl")
3239
include("iterative_wrappers.jl")

src/pardiso.jl

+2
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,8 @@ function SciMLBase.solve(cache::LinearCache, alg::PardisoJL; kwargs...)
8282
return SciMLBase.build_linear_solution(alg,cache.u,nothing,cache)
8383
end
8484

85+
needsconcreteA(alg::PardisoJL) = true
86+
8587
# Add finalizer to release memory
8688
# Pardiso.set_phase!(cache.cacheval, Pardiso.RELEASE_ALL)
8789

0 commit comments

Comments
 (0)