Skip to content

Commit cbbf8d1

Browse files
authored
Merge pull request #210 from SciML/rk/fix_umfpack
Use new ctor in 1.9
2 parents cbeca68 + 28d5b79 commit cbbf8d1

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

src/factorization.jl

+11-8
Original file line numberDiff line numberDiff line change
@@ -275,14 +275,17 @@ function init_cacheval(alg::UMFPACKFactorization, A, b, u, Pl, Pr, maxiters::Int
275275
verbose::Bool, assumptions::OperatorAssumptions)
276276
A = convert(AbstractMatrix, A)
277277
zerobased = SparseArrays.getcolptr(A)[1] == 0
278-
res = SuiteSparse.UMFPACK.UmfpackLU(C_NULL, C_NULL, size(A, 1), size(A, 2),
279-
zerobased ? copy(SparseArrays.getcolptr(A)) :
280-
SuiteSparse.decrement(SparseArrays.getcolptr(A)),
281-
zerobased ? copy(rowvals(A)) :
282-
SuiteSparse.decrement(rowvals(A)),
283-
copy(nonzeros(A)), 0)
284-
finalizer(SuiteSparse.UMFPACK.umfpack_free_symbolic, res)
285-
res
278+
@static if VERSION < v"1.9.0-DEV.1622"
279+
return SuiteSparse.UMFPACK.UmfpackLU(C_NULL, C_NULL, size(A, 1), size(A, 2),
280+
zerobased ? copy(SparseArrays.getcolptr(A)) :
281+
SuiteSparse.decrement(SparseArrays.getcolptr(A)),
282+
zerobased ? copy(rowvals(A)) :
283+
SuiteSparse.decrement(rowvals(A)),
284+
copy(nonzeros(A)), 0)
285+
finalizer(SuiteSparse.UMFPACK.umfpack_free_symbolic, res)
286+
else
287+
return SuiteSparse.UMFPACK.UmfpackLU(A)
288+
end
286289
end
287290

288291
function SciMLBase.solve(cache::LinearCache, alg::UMFPACKFactorization; kwargs...)

0 commit comments

Comments
 (0)