require kwargs for factorization

ChrisRackauckas · ChrisRackauckas · commit f3d00007a93b · 2021-12-13T15:59:47.000-05:00
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "LinearSolve"
 uuid = "7ed4a6bd-45f5-4d41-b270-4a48e9bafcae"
 authors = ["Jonathan <edelman.jonathan.s@gmail.com> and contributors"]
-version = "0.1.3"
+version = "0.1.4"
 
 [deps]
 ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"
diff --git a/src/default.jl b/src/default.jl
@@ -11,7 +11,8 @@ function SciMLBase.solve(cache::LinearCache, alg::Nothing,
     # it makes sense according to the benchmarks, which is dependent on
     # whether MKL or OpenBLAS is being used
     if A isa Matrix
-        if ArrayInterface.can_setindex(cache.b) && (size(A,1) <= 100 ||
+        if eltype(A) <: Union{Float32,Float64,ComplexF32,ComplexF64} &&
+                    ArrayInterface.can_setindex(cache.b) && (size(A,1) <= 100 ||
                                               (isopenblas() && size(A,1) <= 500)
                                              )
             alg = GenericFactorization(;fact_alg=RecursiveFactorization.lu!)
diff --git a/src/factorization.jl b/src/factorization.jl
@@ -1,4 +1,4 @@
-function SciMLBase.solve(cache::LinearCache, alg::AbstractFactorization)
+function SciMLBase.solve(cache::LinearCache, alg::AbstractFactorization; kwargs...)
     if cache.isfresh
         fact = init_cacheval(alg, cache.A, cache.b, cache.u)
         cache = set_cacheval(cache, fact)

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-function SciMLBase.solve(cache::LinearCache, alg::AbstractFactorization)`
	`1`	`+function SciMLBase.solve(cache::LinearCache, alg::AbstractFactorization; kwargs...)`
`2`	`2`	`if cache.isfresh`
`3`	`3`	`fact = init_cacheval(alg, cache.A, cache.b, cache.u)`
`4`	`4`	`cache = set_cacheval(cache, fact)`