Fix #352 and #353 #354
Merged
Fix #352 and #353 #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix breaking change introduced in algolia#352 According to the [documentation](https://github.com/algolia/algoliasearch-rails/blob/master/lib/README.md#630), using custom attributes without a custom `_changed?` method will always cause changes to push to the API. This behavior was lost in algolia#338 Fix unexpected behavior during transactions algolia#353 `@algolia_must_reindex` is reset in every validate call. This means that a record that is updated multiple times in a transaction will only be indexed if the final update marks as must reindex. Update the code so that once `@algolia_must_reindex` is marked as `true`, it remains true until explicitly unset in `algolia_perform_index_tasks`
Gasparila
force-pushed
the
kevin/fix_transaction_issues
branch
from
5987061 to
c1e28a2
Compare
Closed
julienbourdeau
approved these changes
Jun 24, 2019
| # Nil means we don't know if the attribute has changed | ||
| nil | ||
| # We don't know if the attribute has changed, so conservatively assume it has | ||
| true |
|
Hi @Gasparila , Thank you very much for this PR, this is very valuable 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix breaking change introduced in #352
According to the documentation,
using custom attributes without a custom
_changed?method will alwayscause changes to push to the API. This behavior was lost in #338
Fix unexpected behavior during transactions #353
@algolia_must_reindexis reset in every validate call. This means that a recordthat is updated multiple times in a transaction will only be indexed if the
final update marks as must reindex. Update the code so that once
@algolia_must_reindexis marked astrue, it remains true untilexplicitly unset in
algolia_perform_index_tasks