Skip to content

Would you be willing to let me rewrite the C++ section in euclidean? #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
strega-nil opened this issue Sep 17, 2017 · 4 comments
Closed

Comments

@strega-nil
Copy link

I'd like to change the style a bit to make it more similar to standard C++.

Also, the giant banner is unnecessary, and poor for accessibility.

@strega-nil
Copy link
Author

(It's fine if you don't want to allow me to. please allow me to remove the banner tho...)

@june128
Copy link
Member

june128 commented Sep 17, 2017

You could edit the file and open a pull request. Then it's getting merged, if the implementation is better. Also you can edit the files while you're discussing the implementation detail.

@leios
Copy link
Member

leios commented Sep 17, 2017

Yeah, it's fine to update the C++ code, no problem. This week, I want to take all the code and put it in separate, compilable files so I wanted the banner (or at the very least a comment) so it could have compile instructions in it.

I definitely don't mind people re-writing code if it makes it cleaner and easier to understand.

@strega-nil
Copy link
Author

cool :)

Opened an issue at #13 for discussion on compilation flags, and opened a PR at #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants