Skip to content

Commit d7d52c8

Browse files
committed
Adding the zone arg to the app factory
1 parent 6638b9d commit d7d52c8

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/analytics/analytics.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export class AngularFireAnalytics {
3737
) {
3838
// @ts-ignore zapping in the UMD in the build script
3939
const requireAnalytics = from(import('firebase/analytics'));
40-
const app = _firebaseAppFactory(options, nameOrConfig);
40+
const app = _firebaseAppFactory(options, zone, nameOrConfig);
4141

4242
this.analytics = requireAnalytics.pipe(
4343
map(() => app.analytics()),
@@ -63,7 +63,7 @@ export class AngularFireAnalytics {
6363
}
6464
if (automaticallySetCurrentScreen !== false) {
6565
// TODO when is screen_name undefined?
66-
analytics.setCurrentScreen(screen_name || url, { global: outlet == "primary" })
66+
analytics.setCurrentScreen(screen_name || url, { global: outlet == "primary" });
6767
}
6868
}),
6969
runOutsideAngular(zone)

src/remote-config/remote-config.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export class AngularFireRemoteConfig {
4343

4444
this.remoteConfig = requireRemoteConfig.pipe(
4545
map(rc => rc.registerRemoteConfig(firebase)),
46-
map(() => _firebaseAppFactory(options, nameOrConfig)),
46+
map(() => _firebaseAppFactory(options, zone, nameOrConfig)),
4747
map(app => app.remoteConfig()),
4848
tap(rc => {
4949
if (settings) { rc.settings = settings }

0 commit comments

Comments
 (0)