fix time validity check

kytpbs · pennam · commit fac98d7e59d5 · 2024-09-16T09:32:35.000+02:00
diff --git a/src/utility/time/TimeService.cpp b/src/utility/time/TimeService.cpp
@@ -322,7 +322,9 @@ unsigned long TimeServiceClass::getRemoteTime()
 
 bool TimeServiceClass::isTimeValid(unsigned long const time)
 {
-  return (time > EPOCH_AT_COMPILE_TIME);
+  // EPOCH_AT_COMPILE_TIME is in local time, 
+  // so we need to subtract the maximum possible timezone offset to make sure we are less then utc time
+  return (time > (EPOCH_AT_COMPILE_TIME - (/*UTC+14*/ 14 * 60 * 60)));
 }
 
 bool TimeServiceClass::isTimeZoneOffsetValid(long const offset)

Original file line number	Diff line number	Diff line change
`@@ -322,7 +322,9 @@ unsigned long TimeServiceClass::getRemoteTime()`
`322`	`322`
`323`	`323`	`bool TimeServiceClass::isTimeValid(unsigned long const time)`
`324`	`324`	`{`
`325`		`- return (time > EPOCH_AT_COMPILE_TIME);`
	`325`	`+ // EPOCH_AT_COMPILE_TIME is in local time,`
	`326`	`+ // so we need to subtract the maximum possible timezone offset to make sure we are less then utc time`
	`327`	`+ return (time > (EPOCH_AT_COMPILE_TIME - (/UTC+14/ 14 * 60 * 60)));`
`326`	`328`	`}`
`327`	`329`
`328`	`330`	`bool TimeServiceClass::isTimeZoneOffsetValid(long const offset)`