Skip to content

Should we get rid of "mode" #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rmpowell77 opened this issue Dec 10, 2016 · 4 comments
Closed

Should we get rid of "mode" #177

rmpowell77 opened this issue Dec 10, 2016 · 4 comments
Milestone

Comments

@rmpowell77
Copy link
Contributor

setting mode is confusing and hard to get right. Mode isn't part of the saved file anyways.

Do we need this feature anymore? Could we just assume 1 mode? What would this do to marching in other places?

@gmeeker
Copy link

gmeeker commented Dec 13, 2016 via email

@noahsark769
Copy link
Contributor

I think the band playing at NFL games is still very much on the table given that they had a performance at a Raiders game this year :)

That said, it seems like the hash marks could just be configurable on a "per show" basis - I'm not familiar with how the code works right now, but it seems like an entire mode system is unneeded.

@rmpowell77 rmpowell77 added this to the 3.6.0 milestone Feb 8, 2020
@rmpowell77
Copy link
Contributor Author

We should keep mode, but have it per File.

@rmpowell77
Copy link
Contributor Author

This is done in 3.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants