Skip to content

Marlin Inch Mode still shows MM in DRO #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cheton opened this issue Jun 26, 2019 · 0 comments
Open

Marlin Inch Mode still shows MM in DRO #2

cheton opened this issue Jun 26, 2019 · 0 comments
Assignees
@cheton
Labels
bug

Comments

@cheton
Copy link
Contributor

cheton commented Jun 26, 2019

See cncjs/cncjs#498 for details.

Marlin always reports positions in mm, regardless of whether it is in inch (G20) or mm (G21) mode.

We need to provide a fix for the edge branch:
https://github.com/cncjs/cncjs-controller/blob/edge/src/Controller.js#L403-L418
https://github.com/cncjs/cncjs-controller/blob/edge/src/Controller.js#L478-L493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cheton cheton

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect Marlin position reports in inch mode cncjs/cncjs-controller
1 participant
@cheton