Skip to content

option ci reads Changes to our CI configuration, possibly an error #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nbehrnd opened this issue May 4, 2024 · 3 comments
Closed

option ci reads Changes to our CI configuration, possibly an error #1095

nbehrnd opened this issue May 4, 2024 · 3 comments
Labels
good first issue issue-status: pr-created type: refactor

Comments

@nbehrnd
Copy link
Contributor

nbehrnd commented May 4, 2024

Description

I think the instruction about option ci as one of the options to commit an edit can be improved.

Steps to reproduce

  1. edit a git managed project, e.g. in a file test.txt
  2. pick up the file in question by git add test.txt
  3. run cz c, option ci

Current behavior

The description currently reads as

ci: Changes to our CI configuration files and scripts (example scopes: GitLabCI)

Desired behavior

I think it however should read as

ci: Changes to your CI configuration files and scripts (example scopes: GitLabCI)

instead

Screenshots

No response

Environment

  • commitizen (commitizen-3.25.0-py3-none-any.whl.metadata) as fetched by pip (version 24.0) from PyPI
  • Python 3.11.8 as provided by Linux Debian 13/trixie
@nbehrnd
Copy link
Contributor Author

nbehrnd commented May 4, 2024

Initially filed in as a discussion (#1036) by 2024-03-22 about then version 3.20.0 of commitizen. So far (till today, 2024-05-04), the entry however did not receive a comment.

@woile
Copy link
Member

woile commented May 4, 2024

Yeah, it depends on the perspective of how you read it, I don't mind changing it to your, feel free to open a PR 👍🏻

@nbehrnd nbehrnd mentioned this issue May 14, 2024
Merged
4 tasks
Lee-W pushed a commit that referenced this issue May 15, 2024
@nbehrnd @Lee-W
refactor: strip possessive from note about ci option
4bd2525 
A description of the commit option affecting the ci does not
require a "our", nor "your".  It doesn't relate to "a local"
vs. "a remote repository", either.  To ease conveying the
intent,[1] the possessive is removed.

[1] #1095

Signed-off-by: Norwid Behrnd <[email protected]>
@Lee-W
Copy link
Member

Lee-W commented May 20, 2024

Closed by #1107

@Lee-W Lee-W closed this as completed May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue issue-status: pr-created type: refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@woile @Lee-W @nbehrnd