Skip to content

Commit 9025520

Browse files
woothuwoothu
committed
fix: fix icon names in CDataTable component
1 parent d74053a commit 9025520

File tree

2 files changed

+35
-81
lines changed

2 files changed

+35
-81
lines changed

‎src/components/table/CDataTable.vue

+5-5
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
>
6666
<CIcon
6767
width="18"
68-
:content="$options.icons.arrowTop"
68+
:content="$options.icons.cilArrowTop"
6969
:class="iconClasses(index)"
7070
/>
7171
</slot>
@@ -144,7 +144,7 @@
144144
<h2>{{ passedItems.length ? 'No filtering results ' : 'No items'}}
145145
<CIcon
146146
width="30"
147-
:content="$options.icons.ban"
147+
:content="$options.icons.cilBan"
148148
class="text-danger mb-2"
149149
/>
150150
</h2>
@@ -174,7 +174,7 @@
174174
>
175175
<CIcon
176176
width="18"
177-
name="arrowTop"
177+
:content="$options.icons.cilArrowTop"
178178
:class="iconClasses(index)"
179179
/>
180180
</slot>
@@ -211,11 +211,11 @@
211211
import CSpinner from '../spinner/CSpinner'
212212
import CPagination from '../pagination/CPagination'
213213
import { CIcon } from '@coreui/icons-vue/index.js'
214-
import { arrowTop, ban } from '@coreui/icons'
214+
import { cilArrowTop, cilBan } from '@coreui/icons'
215215
216216
export default {
217217
name: 'CDataTable',
218-
icons: { arrowTop, ban },
218+
icons: { cilArrowTop, cilBan },
219219
components: {
220220
CPagination,
221221
CSpinner,

‎src/components/table/tests/__snapshots__/CDataTable.spec.js.snap

+30-76
Original file line numberDiff line numberDiff line change
@@ -36,20 +36,9 @@ exports[`CDataTable renders correctly 1`] = `
3636
width="30"
3737
xmlns="http://www.w3.org/2000/svg"
3838
>
39-
40-
41-
42-
<title>
43-
ban
44-
</title>
45-
46-
4739
<path
4840
d="M19.955 4.045c-2.036-2.036-4.848-3.295-7.955-3.295-6.213 0-11.25 5.037-11.25 11.25 0 3.107 1.259 5.919 3.295 7.955v0c2.036 2.036 4.848 3.295 7.955 3.295 6.213 0 11.25-5.037 11.25-11.25 0-3.107-1.259-5.919-3.295-7.955v0zM12 2.25c0.003 0 0.006 0 0.009 0 2.431 0 4.653 0.894 6.356 2.37l-0.012-0.010-13.743 13.743c-1.466-1.691-2.36-3.913-2.36-6.344 0-0.003 0-0.006 0-0.009v0c0-5.376 4.374-9.75 9.75-9.75zM12 21.75c-0.002 0-0.005 0-0.008 0-2.419 0-4.632-0.885-6.332-2.349l0.013 0.011 13.739-13.739c1.453 1.687 2.338 3.9 2.338 6.319 0 0.003 0 0.006 0 0.009v-0c0 5.376-4.374 9.75-9.75 9.75z"
4941
/>
50-
51-
52-
5342
</svg>
5443
</h2>
5544
</div>
@@ -172,20 +161,9 @@ exports[`CDataTable renders correctly 2`] = `
172161
width="18"
173162
xmlns="http://www.w3.org/2000/svg"
174163
>
175-
176-
177-
178-
<title>
179-
arrow-top
180-
</title>
181-
182-
183164
<path
184165
d="M18.311 7.061l-6.311-6.311-6.31 6.311 1.061 1.061 4.5-4.5v19.593h1.5v-19.593l4.5 4.5 1.061-1.061z"
185166
/>
186-
187-
188-
189167
</svg>
190168
</th>
191169
<th
@@ -204,20 +182,9 @@ exports[`CDataTable renders correctly 2`] = `
204182
width="18"
205183
xmlns="http://www.w3.org/2000/svg"
206184
>
207-
208-
209-
210-
<title>
211-
arrow-top
212-
</title>
213-
214-
215185
<path
216186
d="M18.311 7.061l-6.311-6.311-6.31 6.311 1.061 1.061 4.5-4.5v19.593h1.5v-19.593l4.5 4.5 1.061-1.061z"
217187
/>
218-
219-
220-
221188
</svg>
222189
</th>
223190
<th
@@ -236,20 +203,9 @@ exports[`CDataTable renders correctly 2`] = `
236203
width="18"
237204
xmlns="http://www.w3.org/2000/svg"
238205
>
239-
240-
241-
242-
<title>
243-
arrow-top
244-
</title>
245-
246-
247206
<path
248207
d="M18.311 7.061l-6.311-6.311-6.31 6.311 1.061 1.061 4.5-4.5v19.593h1.5v-19.593l4.5 4.5 1.061-1.061z"
249208
/>
250-
251-
252-
253209
</svg>
254210
</th>
255211
<th
@@ -268,20 +224,9 @@ exports[`CDataTable renders correctly 2`] = `
268224
width="18"
269225
xmlns="http://www.w3.org/2000/svg"
270226
>
271-
272-
273-
274-
<title>
275-
arrow-top
276-
</title>
277-
278-
279227
<path
280228
d="M18.311 7.061l-6.311-6.311-6.31 6.311 1.061 1.061 4.5-4.5v19.593h1.5v-19.593l4.5 4.5 1.061-1.061z"
281229
/>
282-
283-
284-
285230
</svg>
286231
</th>
287232
<th
@@ -300,20 +245,9 @@ exports[`CDataTable renders correctly 2`] = `
300245
width="18"
301246
xmlns="http://www.w3.org/2000/svg"
302247
>
303-
304-
305-
306-
<title>
307-
arrow-top
308-
</title>
309-
310-
311248
<path
312249
d="M18.311 7.061l-6.311-6.311-6.31 6.311 1.061 1.061 4.5-4.5v19.593h1.5v-19.593l4.5 4.5 1.061-1.061z"
313250
/>
314-
315-
316-
317251
</svg>
318252
</th>
319253
</tr>
@@ -575,10 +509,14 @@ exports[`CDataTable renders correctly 2`] = `
575509
576510
<svg
577511
class="c-icon c-icon-custom-size icon-transition position-absolute arrow-position rotate-icon"
578-
viewBox="0 0 64 64"
512+
viewBox="0 0 24 24"
579513
width="18"
580514
xmlns="http://www.w3.org/2000/svg"
581-
/>
515+
>
516+
<path
517+
d="M18.311 7.061l-6.311-6.311-6.31 6.311 1.061 1.061 4.5-4.5v19.593h1.5v-19.593l4.5 4.5 1.061-1.061z"
518+
/>
519+
</svg>
582520
</th>
583521
<th
584522
class="position-relative pr-4"
@@ -592,10 +530,14 @@ exports[`CDataTable renders correctly 2`] = `
592530
593531
<svg
594532
class="c-icon c-icon-custom-size icon-transition position-absolute arrow-position transparent"
595-
viewBox="0 0 64 64"
533+
viewBox="0 0 24 24"
596534
width="18"
597535
xmlns="http://www.w3.org/2000/svg"
598-
/>
536+
>
537+
<path
538+
d="M18.311 7.061l-6.311-6.311-6.31 6.311 1.061 1.061 4.5-4.5v19.593h1.5v-19.593l4.5 4.5 1.061-1.061z"
539+
/>
540+
</svg>
599541
</th>
600542
<th
601543
class="position-relative pr-4"
@@ -609,10 +551,14 @@ exports[`CDataTable renders correctly 2`] = `
609551
610552
<svg
611553
class="c-icon c-icon-custom-size icon-transition position-absolute arrow-position transparent"
612-
viewBox="0 0 64 64"
554+
viewBox="0 0 24 24"
613555
width="18"
614556
xmlns="http://www.w3.org/2000/svg"
615-
/>
557+
>
558+
<path
559+
d="M18.311 7.061l-6.311-6.311-6.31 6.311 1.061 1.061 4.5-4.5v19.593h1.5v-19.593l4.5 4.5 1.061-1.061z"
560+
/>
561+
</svg>
616562
</th>
617563
<th
618564
class="position-relative pr-4"
@@ -626,10 +572,14 @@ exports[`CDataTable renders correctly 2`] = `
626572
627573
<svg
628574
class="c-icon c-icon-custom-size icon-transition position-absolute arrow-position transparent"
629-
viewBox="0 0 64 64"
575+
viewBox="0 0 24 24"
630576
width="18"
631577
xmlns="http://www.w3.org/2000/svg"
632-
/>
578+
>
579+
<path
580+
d="M18.311 7.061l-6.311-6.311-6.31 6.311 1.061 1.061 4.5-4.5v19.593h1.5v-19.593l4.5 4.5 1.061-1.061z"
581+
/>
582+
</svg>
633583
</th>
634584
<th
635585
class="position-relative pr-4"
@@ -643,10 +593,14 @@ exports[`CDataTable renders correctly 2`] = `
643593
644594
<svg
645595
class="c-icon c-icon-custom-size icon-transition position-absolute arrow-position transparent"
646-
viewBox="0 0 64 64"
596+
viewBox="0 0 24 24"
647597
width="18"
648598
xmlns="http://www.w3.org/2000/svg"
649-
/>
599+
>
600+
<path
601+
d="M18.311 7.061l-6.311-6.311-6.31 6.311 1.061 1.061 4.5-4.5v19.593h1.5v-19.593l4.5 4.5 1.061-1.061z"
602+
/>
603+
</svg>
650604
</th>
651605
</tr>
652606
</tfoot>

0 commit comments

Comments
 (0)