Skip to content

Commit d800c7d

Browse files
authored
show gdbgui version in more places (#401)
1 parent 0e636d5 commit d800c7d

File tree

6 files changed

+22
-9
lines changed

6 files changed

+22
-9
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
<!-- add an 'x' in the brackets below -->
2-
- [] I have added an entry to `docs/changelog.md`
2+
- [] I have added an entry to `CHANGELOG.md`, or an entry is not needed for this change
33

44
## Summary of changes
5+
<!--
6+
* fixed bug
7+
* added new feature
8+
-->
59

610
## Test plan
711
<!-- provide evidence of testing, preferably with command(s) that can be copy+pasted by others -->

CHANGELOG.md

+4-3
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,14 @@
22

33
## 0.15.0.0
44

5-
No new features, just bugfixes and compatibility fixes
5+
This release is focused mostly on Python 3.9 compatibility and updating dependencies
66

7-
- Support only Python 3.9 (though other Python versions may work)
7+
- Support only Python 3.9 (though other Python versions may still work)
88
- Use only the threading async model for flask-socketio. No longer support gevent or eventlet.
99
- [bugfix] Catch exception if gdb used in tty window crashes instead of gdbgui crashing along with it
10-
- Disable pagination in gdb ttyy by default. It can be turned back on with `set pagination off`.
10+
- Disable pagination in gdb tty by default. It can be turned back on with `set pagination off`.
1111
- Upgrade various dependencies for both the backend and frontend (Python and JavaScript)
12+
- Display gdbgui version in "about" and "session information"
1213

1314
## 0.14.0.2
1415

MANIFEST.in

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ prune docker
1717
prune images
1818
prune gdbgui/__pycache__
1919
prune gdbgui/server/__pycache__
20-
prune gdbgui/src/
20+
prune gdbgui/src
2121

2222
exclude mypy.ini
2323
exclude .eslintrc.json

gdbgui/server/app.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ def read_and_forward_gdb_and_pty_output():
260260
pass
261261

262262
except Exception:
263-
logger.error(traceback.format_exc())
263+
logger.error("caught exception, continuing:" + traceback.format_exc())
264264

265265
debug_sessions_to_remove += check_and_forward_pty_output()
266266
for debug_session in set(debug_sessions_to_remove):

gdbgui/src/js/InitialStoreData.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const initial_store_data = {
1414
// @ts-expect-error ts-migrate(2304) FIXME: Cannot find name 'initial_data'.
1515
gdbgui_version: initial_data.gdbgui_version,
1616
latest_gdbgui_version: "(not fetched)",
17-
gdb_version: undefined, // this is parsed from gdb's output
17+
gdb_version: "unknown", // this is parsed from gdb's output
1818
gdb_version_array: [], // this is parsed from gdb's output
1919
gdb_pid: undefined,
2020
// @ts-expect-error ts-migrate(2304) FIXME: Cannot find name 'initial_data'.

gdbgui/src/js/TopBar.tsx

+10-2
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,13 @@ let About = {
4545
show_about: function() {
4646
Actions.show_modal(
4747
"About gdbgui",
48-
<React.Fragment>Copyright © Chad Smith, chadsmith.dev</React.Fragment>
48+
<div>
49+
<div>gdbgui, v{store.get("gdbgui_version")}</div>
50+
<div>Copyright © Chad Smith</div>
51+
<div>
52+
<a href="https://chadsmith.dev">chadsmith.dev</a>
53+
</div>
54+
</div>
4955
);
5056
}
5157
};
@@ -59,10 +65,12 @@ let show_session_info = function() {
5965
<tr>
6066
<td>gdb version: {store.get("gdb_version")}</td>
6167
</tr>
62-
6368
<tr>
6469
<td>gdb pid for this tab: {store.get("gdb_pid")}</td>
6570
</tr>
71+
<tr>
72+
<td>gdbgui v{store.get("gdbgui_version")}</td>
73+
</tr>
6674
</tbody>
6775
</table>
6876
</React.Fragment>

0 commit comments

Comments
 (0)