Skip to content

Commit 29d135e

Browse files
Pin vscode version in CI for windows (#2901)
We had already pinned the version for mac and Linux: #2878 but it appears that we have the same problem on windows its just crashing with error code 0 which means our test runner wasn't signalling the failure. Test run crashes on windows with false negative. https://github.com/cursorless-dev/cursorless/actions/runs/14509376075/job/40704611423?pr=2893 It appears that it's `vscode.window.showTextDocument` in our `openNewEditor` utility that causes this. It's not always on the same test case. By default it crashes in the scope tests, but if I disable the scope test the same error occurs in our recorded tests that of course uses the same `openNewEditor` function. I can't recreate this locally. Looks like a memory leak or similar.
1 parent 3375634 commit 29d135e

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

packages/test-harness/src/launchVscodeAndRunTests.ts

+1-5
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,7 @@ export async function launchVscodeAndRunTests(extensionTestsPath: string) {
3939
// NB: Because of a CI crashing issue the vscode version is pinned.
4040
// https://github.com/cursorless-dev/cursorless/issues/2878
4141

42-
const vscodeVersion = useLegacyVscode
43-
? "1.82.0"
44-
: os.platform() === "win32"
45-
? "stable"
46-
: "1.97.2";
42+
const vscodeVersion = useLegacyVscode ? "1.82.0" : "1.97.2";
4743
const vscodeExecutablePath = await downloadAndUnzipVSCode(vscodeVersion);
4844
const [cli, ...args] =
4945
resolveCliArgsFromVSCodeExecutablePath(vscodeExecutablePath);

0 commit comments

Comments
 (0)