Skip to content

Commit 655ef70

Browse files
committed
Fix things
Signed-off-by: siri-varma <[email protected]>
1 parent 6e303fa commit 655ef70

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

examples/src/main/java/io/dapr/examples/conversation/DemoConversationAI.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public static void main(String[] args) {
4141
.setContextId("contextId")
4242
.setScrubPii(true).setTemperature(1.1d));
4343
ConversationResponse response = responseMono.block();
44-
System.out.printf("Conversation output: %s", response.getConversationOutpus().get(0).getResult());
44+
System.out.printf("Conversation output: %s", response.getConversationOutputs().get(0).getResult());
4545
} catch (Exception e) {
4646
throw new RuntimeException(e);
4747
}

sdk/src/main/java/io/dapr/client/domain/ConversationOutput.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public class ConversationOutput {
3333
*/
3434
public ConversationOutput(String result, Map<String, byte[]> parameters) {
3535
this.result = result;
36-
this.parameters = parameters;
36+
this.parameters = Map.copyOf(parameters);
3737
}
3838

3939
/**
@@ -51,6 +51,6 @@ public String getResult() {
5151
* @return parameters.
5252
*/
5353
public Map<String, byte[]> getParameters() {
54-
return Collections.unmodifiableMap(this.parameters);
54+
return this.parameters;
5555
}
5656
}

sdk/src/main/java/io/dapr/client/domain/ConversationRequest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public class ConversationRequest {
3636
*/
3737
public ConversationRequest(String name, List<ConversationInput> inputs) {
3838
this.name = name;
39-
this.inputs = inputs;
39+
this.inputs = List.copyOf(inputs);
4040
}
4141

4242
/**

sdk/src/main/java/io/dapr/client/domain/ConversationResponse.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public class ConversationResponse {
3333
*/
3434
public ConversationResponse(String contextId, List<ConversationOutput> outputs) {
3535
this.contextId = contextId;
36-
this.outputs = outputs;
36+
this.outputs = List.copyOf(outputs);
3737
}
3838

3939
/**
@@ -50,7 +50,7 @@ public String getContextId() {
5050
*
5151
* @return List{@link ConversationOutput}.
5252
*/
53-
public List<ConversationOutput> getConversationOutpus() {
54-
return Collections.unmodifiableList(this.outputs);
53+
public List<ConversationOutput> getConversationOutputs() {
54+
return this.outputs;
5555
}
5656
}

sdk/src/test/java/io/dapr/client/DaprPreviewClientGrpcTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -650,7 +650,7 @@ public void converseShouldReturnConversationResponseWhenRequiredInputsAreValid()
650650
assertEquals("openai", conversationRequest.getName());
651651
assertEquals("Hello there", conversationRequest.getInputs(0).getContent());
652652
assertEquals("Hello How are you",
653-
response.getConversationOutpus().get(0).getResult());
653+
response.getConversationOutputs().get(0).getResult());
654654
}
655655

656656
@Test
@@ -694,7 +694,7 @@ public void converseShouldReturnConversationResponseWhenRequiredAndOptionalInput
694694
assertEquals("Assistant", conversationRequest.getInputs(0).getRole());
695695
assertEquals("contextId", response.getContextId());
696696
assertEquals("Hello How are you",
697-
response.getConversationOutpus().get(0).getResult());
697+
response.getConversationOutputs().get(0).getResult());
698698
}
699699

700700
@Test

0 commit comments

Comments
 (0)