Skip to content

Commit c27d3ab

Browse files
authored
Merge branch 'master' into users/svegiraju/conversation-api-2
2 parents 88fe015 + ff917ac commit c27d3ab

File tree

5 files changed

+58
-35
lines changed

5 files changed

+58
-35
lines changed

.github/workflows/create-release.yml

+1-18
Original file line numberDiff line numberDiff line change
@@ -53,21 +53,4 @@ jobs:
5353
git remote set-url origin https://x-access-token:${{ secrets.DAPR_BOT_TOKEN }}@github.com/${GITHUB_REPOSITORY}.git
5454
# Copy first to allow automation to use the latest version and not the release branch's version.
5555
cp -R ./.github/scripts ${RUNNER_TEMP}/
56-
${RUNNER_TEMP}/scripts/create-release.sh ${{ inputs.rel_version }}
57-
trigger:
58-
name: Triggers the Dapr SDK build
59-
runs-on: ubuntu-latest
60-
needs: create-release
61-
steps:
62-
- name: Identify build ref to trigger build and release.
63-
run: |
64-
if [[ "${{ inputs.rel_version }}" == *"SNAPSHOT"* ]]; then
65-
echo "BUILD_GIT_REF=master" >> $GITHUB_ENV
66-
else
67-
echo "BUILD_GIT_REF=v${{ inputs.rel_version }}" >> $GITHUB_ENV
68-
fi
69-
- name: Triggers the build and release.
70-
env:
71-
GITHUB_TOKEN: ${{ secrets.DAPR_BOT_TOKEN }}
72-
run: |
73-
gh workflow run build.yml --repo ${GITHUB_REPOSITORY} --ref '${{ env.BUILD_GIT_REF }}'
56+
${RUNNER_TEMP}/scripts/create-release.sh ${{ inputs.rel_version }}

sdk/src/test/java/io/dapr/client/DaprClientBuilderTest.java

+16-5
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import io.dapr.exceptions.DaprException;
1919
import io.dapr.serializer.DaprObjectSerializer;
2020
import org.junit.jupiter.api.Test;
21+
import org.junit.jupiter.api.AfterEach;
2122

2223
import static org.junit.jupiter.api.Assertions.assertNotNull;
2324
import static org.junit.jupiter.api.Assertions.assertThrows;
@@ -27,6 +28,16 @@
2728

2829
public class DaprClientBuilderTest {
2930

31+
private DaprClient client;
32+
33+
@AfterEach
34+
public void cleanup() throws Exception {
35+
if (client != null) {
36+
client.close();
37+
client = null;
38+
}
39+
}
40+
3041
@Test
3142
public void build() {
3243
DaprObjectSerializer objectSerializer = mock(DaprObjectSerializer.class);
@@ -35,17 +46,17 @@ public void build() {
3546
DaprClientBuilder daprClientBuilder = new DaprClientBuilder();
3647
daprClientBuilder.withObjectSerializer(objectSerializer);
3748
daprClientBuilder.withStateSerializer(stateSerializer);
38-
DaprClient daprClient = daprClientBuilder.build();
39-
assertNotNull(daprClient);
49+
client = daprClientBuilder.build();
50+
assertNotNull(client);
4051
}
4152

4253
@Test
4354
public void buildWithOverrideSidecarIP() {
4455
DaprClientBuilder daprClientBuilder = new DaprClientBuilder();
4556
daprClientBuilder.withPropertyOverride(Properties.SIDECAR_IP, "unknownhost");
46-
DaprClient daprClient = daprClientBuilder.build();
47-
assertNotNull(daprClient);
48-
DaprException thrown = assertThrows(DaprException.class, () -> { daprClient.getMetadata().block(); });
57+
client = daprClientBuilder.build();
58+
assertNotNull(client);
59+
DaprException thrown = assertThrows(DaprException.class, () -> { client.getMetadata().block(); });
4960
assertTrue(thrown.toString().contains("UNAVAILABLE"), thrown.toString());
5061

5162
}

spring-boot-examples/consumer-app/pom.xml

+8-9
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@
1212
<name>consumer-app</name>
1313
<description>Spring Boot, Testcontainers and Dapr Integration Examples :: Consumer App</description>
1414

15-
<properties>
16-
<springboot.version>3.2.6</springboot.version>
17-
</properties>
1815

1916
<dependencyManagement>
2017
<dependencies>
@@ -37,12 +34,6 @@
3734
<groupId>org.springframework.boot</groupId>
3835
<artifactId>spring-boot-starter-actuator</artifactId>
3936
</dependency>
40-
<dependency>
41-
<groupId>io.dapr.spring</groupId>
42-
<artifactId>dapr-spring-boot-starter</artifactId>
43-
<version>${dapr-java-sdk.alpha-version}</version>
44-
</dependency>
45-
4637
<dependency>
4738
<groupId>io.dapr.spring</groupId>
4839
<artifactId>dapr-spring-boot-starter</artifactId>
@@ -93,6 +84,14 @@
9384
<groupId>org.springframework.boot</groupId>
9485
<artifactId>spring-boot-maven-plugin</artifactId>
9586
</plugin>
87+
<plugin>
88+
<groupId>org.apache.maven.plugins</groupId>
89+
<artifactId>maven-site-plugin</artifactId>
90+
<version>3.12.1</version>
91+
<configuration>
92+
<skip>true</skip>
93+
</configuration>
94+
</plugin>
9695
</plugins>
9796
</build>
9897

spring-boot-examples/pom.xml

+25
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,34 @@
1313
<version>0.15.0-SNAPSHOT</version>
1414
<packaging>pom</packaging>
1515

16+
<properties>
17+
<maven.deploy.skip>true</maven.deploy.skip>
18+
</properties>
19+
1620
<modules>
1721
<module>producer-app</module>
1822
<module>consumer-app</module>
1923
</modules>
2024

25+
<build>
26+
<pluginManagement>
27+
<plugins>
28+
<plugin>
29+
<groupId>org.springframework.boot</groupId>
30+
<artifactId>spring-boot-maven-plugin</artifactId>
31+
<version>${springboot.version}</version>
32+
</plugin>
33+
</plugins>
34+
</pluginManagement>
35+
<plugins>
36+
<plugin>
37+
<groupId>org.apache.maven.plugins</groupId>
38+
<artifactId>maven-site-plugin</artifactId>
39+
<version>3.12.1</version>
40+
<configuration>
41+
<skip>true</skip>
42+
</configuration>
43+
</plugin>
44+
</plugins>
45+
</build>
2146
</project>

spring-boot-examples/producer-app/pom.xml

+8-3
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,6 @@
1313
<name>producer-app</name>
1414
<description>Spring Boot, Testcontainers and Dapr Integration Examples :: Producer App</description>
1515

16-
<properties>
17-
<springboot.version>3.2.6</springboot.version>
18-
</properties>
1916

2017
<dependencyManagement>
2118
<dependencies>
@@ -80,6 +77,14 @@
8077
<groupId>org.springframework.boot</groupId>
8178
<artifactId>spring-boot-maven-plugin</artifactId>
8279
</plugin>
80+
<plugin>
81+
<groupId>org.apache.maven.plugins</groupId>
82+
<artifactId>maven-site-plugin</artifactId>
83+
<version>3.12.1</version>
84+
<configuration>
85+
<skip>true</skip>
86+
</configuration>
87+
</plugin>
8388
</plugins>
8489
</build>
8590
</project>

0 commit comments

Comments
 (0)