Skip to content

Commit 6804dfe

Browse files
committed
Event: Warn and fill event aliases
Fixes jquery#230
1 parent 9e3dfcb commit 6804dfe

File tree

2 files changed

+32
-0
lines changed

2 files changed

+32
-0
lines changed

src/event.js

+18
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,20 @@ jQuery.each( [ "load", "unload", "error" ], function( _, name ) {
7575

7676
} );
7777

78+
jQuery.each( ( "blur focus focusin focusout resize scroll click dblclick " +
79+
"mousedown mouseup mousemove mouseover mouseout mouseenter mouseleave " +
80+
"change select submit keydown keypress keyup contextmenu" ).split( " " ),
81+
function( i, name ) {
82+
83+
// Handle event binding
84+
jQuery.fn[ name ] = function( data, fn ) {
85+
migrateWarn( "jQuery.fn." + name + "() is deprecated" );
86+
return arguments.length > 0 ?
87+
this.on( name, null, data, fn ) :
88+
this.trigger( name );
89+
};
90+
} );
91+
7892
// Trigger "ready" event only once, on document ready
7993
jQuery( function() {
8094
jQuery( window.document ).triggerHandler( "ready" );
@@ -107,5 +121,9 @@ jQuery.fn.extend( {
107121
return arguments.length === 1 ?
108122
this.off( selector, "**" ) :
109123
this.off( types, selector || "**", fn );
124+
},
125+
hover: function( fnOver, fnOut ) {
126+
migrateWarn( "jQuery.fn.hover() is deprecated" );
127+
return this.on( "mouseenter", fnOver ).on( "mouseleave", fnOut || fnOver );
110128
}
111129
} );

test/event.js

+14
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,20 @@ QUnit.test( ".delegate() and .undelegate()", function( assert ) {
9494
} );
9595
} );
9696

97+
QUnit.test( "Event aliases", function( assert) {
98+
assert.expect( 8 );
99+
100+
var $div = jQuery( "<div />" );
101+
102+
"scroll click submit keydown".split( " " ).forEach( function( name ) {
103+
expectWarning( "." + name + "()", 1, function() {
104+
$div[ name ]( function( event ) {
105+
assert.equal( event.type, name, name)
106+
} )[ name ]();
107+
} );
108+
} );
109+
} );
110+
97111
test( "custom ready", function( assert ) {
98112
assert.expect( 2 );
99113

0 commit comments

Comments
 (0)