Skip to content

Check for reuse of old error/warning codes #13545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
frangio opened this issue Sep 20, 2022 · 0 comments · May be fixed by #16003
Open

Check for reuse of old error/warning codes #13545

frangio opened this issue Sep 20, 2022 · 0 comments · May be fixed by #16003
Labels
low effort There is not much implementation work to be done. The task is very easy or tiny. medium impact Default level of impact must have eventually Something we consider essential but not enough to prevent us from releasing Solidity 1.0 without it. needs design The proposal is too vague to be implemented right away testing 🔨

Comments

@frangio
Copy link
Contributor

frangio commented Sep 20, 2022

Some error codes have been removed and are no longer emitted (for example, 8760 for shadowing of opcodes). There is currently a risk that those codes are reintroduced with a different meaning.

scripts/error_codes.py should be amended to include a list of removed error codes and verify that they are not in use in the codebase.
@cameel cameel added testing 🔨 low effort There is not much implementation work to be done. The task is very easy or tiny. medium impact Default level of impact must have eventually Something we consider essential but not enough to prevent us from releasing Solidity 1.0 without it. labels Sep 20, 2022
This was referenced Sep 20, 2022
Merged
Merged
@cameel cameel added the needs design The proposal is too vague to be implemented right away label Oct 6, 2022
@vlad-khramov vlad-khramov linked a pull request Apr 12, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low effort There is not much implementation work to be done. The task is very easy or tiny. medium impact Default level of impact must have eventually Something we consider essential but not enough to prevent us from releasing Solidity 1.0 without it. needs design The proposal is too vague to be implemented right away testing 🔨
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inventory of removed error codes to prevent reuse vlad-khramov/solidity
2 participants
@cameel @frangio