Skip to content

Commit fd8a5e1

Browse files
committed
test: remove token decoded test since we no longer check the token
1 parent b73670f commit fd8a5e1

File tree

4 files changed

+6
-40
lines changed

4 files changed

+6
-40
lines changed

src/firebase_functions/https_fn.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -352,8 +352,7 @@ class CallableRequest(_typing.Generic[_core.T]):
352352
_C2 = _typing.Callable[[CallableRequest[_typing.Any]], _typing.Any]
353353

354354

355-
def _on_call_handler(func: _C2,
356-
request: Request,
355+
def _on_call_handler(func: _C2, request: Request,
357356
enforce_app_check: bool) -> Response:
358357
try:
359358
if not _util.valid_on_call_request(request):

src/firebase_functions/private/util.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,9 @@ def as_dict(self) -> dict:
211211
}
212212

213213

214-
def _on_call_check_auth_token(request: _Request) -> None | _typing.Literal[OnCallTokenState.INVALID] | dict[str, _typing.Any]:
214+
def _on_call_check_auth_token(
215+
request: _Request
216+
) -> None | _typing.Literal[OnCallTokenState.INVALID] | dict[str, _typing.Any]:
215217
"""
216218
Validates the auth token in a callable request.
217219
If verify_token is False, the token will be decoded without verification.

src/firebase_functions/tasks_fn.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@
3232
_C1 = _typing.Callable[[Request], Response]
3333
_C2 = _typing.Callable[[CallableRequest[_typing.Any]], _typing.Any]
3434

35-
def _on_call_handler(func: _C2,
36-
request: Request) -> Response:
35+
36+
def _on_call_handler(func: _C2, request: Request) -> Response:
3737
try:
3838
if not _util.valid_on_call_request(request):
3939
_logging.error("Invalid request, unable to process.")

tests/test_tasks_fn.py

-35
Original file line numberDiff line numberDiff line change
@@ -71,41 +71,6 @@ def example(request: CallableRequest[object]) -> str:
7171
'{"result":"Hello World"}\n',
7272
)
7373

74-
def test_token_is_decoded(self):
75-
"""
76-
Test that the token is decoded instead of verifying auth first.
77-
"""
78-
app = Flask(__name__)
79-
80-
@on_task_dispatched()
81-
def example(request: CallableRequest[object]) -> str:
82-
auth = request.auth
83-
# Make mypy happy
84-
if auth is None:
85-
self.fail("Auth is None")
86-
return "No Auth"
87-
self.assertEqual(auth.token["sub"], "firebase")
88-
self.assertEqual(auth.token["name"], "John Doe")
89-
return "Hello World"
90-
91-
with app.test_request_context("/"):
92-
# pylint: disable=line-too-long
93-
test_token = "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiJmaXJlYmFzZSIsIm5hbWUiOiJKb2huIERvZSJ9.74A24Y821E7CZx8aYCsCKo0Y-W0qXwqME-14QlEMcB0"
94-
environ = EnvironBuilder(
95-
method="POST",
96-
headers={
97-
"Authorization": f"Bearer {test_token}"
98-
},
99-
json={
100-
"data": {
101-
"test": "value"
102-
},
103-
},
104-
).get_environ()
105-
request = Request(environ)
106-
response = example(request)
107-
self.assertEqual(response.status_code, 200)
108-
10974
def test_calls_init(self):
11075
hello = None
11176

0 commit comments

Comments
 (0)