-
Notifications
You must be signed in to change notification settings - Fork 143
Portal docs appear to be outdated #573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
These containe some Flatpak specific portal docs that aren't there in XDG portal docs but the rest of it is indeed overlapped. @TingPing might know the steps to generate them. Building Flatpak just gives a bunch of html files, I don't know how they were combined into one. |
Could the XDG portals be removed from the flatpak docs, so that the flatpak docs only document the flatpak-specific portals, and reference the XDG portal upstream docs for the XDG portals? Currently, it's quite confusing, and it's easy to see only the older XDG portal docs, as the upstream docs aren't linked anywhere 🤔 |
lf these are autogenerated it will be easier to set up a workflow to keep them in sync and update. Removing needs to be done manually by someone everytime they update. |
I'm closing this issue. I'm sorry but I no longer care 🤷 |
I noticed that the flatpak portal documentation differs from the xdg portal documentation, with the latter appearing to be more recent.
Specifically, the flatpak documentation for the Settings portal documents only
Read
andReadAll
, does not document the confusing return value ofRead
, and only includes thecolor-scheme
settings.The xdg portal documentation for the Settings portal documents the newer
ReadOne
method, deprecatesRead
due to its confusing return value, and also mentions theaccent-color
andcontrast
settings.As such it appears that the XDG portal documentation is newer, and the flatpak portal docs should be updated.
I can make a pull request but I'm not sure how to proceed. The portal reference documentation in this repo comes from
docs/portal-docs.html
which doesn't look hand written, but appears to be generated. Unfortunately, there's no reference to the source and how to regenerate it, and the last update commit from three years ago doesn't have any details in its commit message 🤷And, given that up to date portal documentation exists at https://flatpak.github.io/xdg-desktop-portal/docs/index.html, should the flatpak portal docs perhaps just be removed and replaced with a link to that upstream documentation?
The text was updated successfully, but these errors were encountered: