Apply suggestions from code review

mydea · andreiborza · mydea · commit 7186fa9f39f6 · 2025-05-12T12:37:01.000+02:00
Co-authored-by: Andrei &lt;168741329+andreiborza@users.noreply.github.com&gt;
diff --git a/packages/node/src/integrations/http/SentryHttpInstrumentation.ts b/packages/node/src/integrations/http/SentryHttpInstrumentation.ts
@@ -176,7 +176,8 @@ export class SentryHttpInstrumentation extends InstrumentationBase<SentryHttpIns
           subscribe('http.client.request.error', onHttpClientRequestError);
 
           // NOTE: This channel only exist since Node 23
-          // Before that, outgoing requests are not patched, sadly
+          // Before that, outgoing requests are not patched
+          // and trace headers are not propagated, sadly.
           if (this.getConfig().propagateTraceInOutgoingRequests) {
             subscribe('http.client.request.created', onHttpClientRequestCreated);
           }

Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,8 @@ export class SentryHttpInstrumentation extends InstrumentationBase<SentryHttpIns`
`176`	`176`	`subscribe('http.client.request.error', onHttpClientRequestError);`
`177`	`177`
`178`	`178`	`// NOTE: This channel only exist since Node 23`
`179`		`- // Before that, outgoing requests are not patched, sadly`
	`179`	`+ // Before that, outgoing requests are not patched`
	`180`	`+ // and trace headers are not propagated, sadly.`
`180`	`181`	`if (this.getConfig().propagateTraceInOutgoingRequests) {`
`181`	`182`	`subscribe('http.client.request.created', onHttpClientRequestCreated);`
`182`	`183`	`}`