You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ref(bun): Ensure bun is latest for local tests (#16244)
I noticed that my bun version locally was old, leading to weird test
issues.
Now, our install script will ensure this is the latest version. On CI,
we already test against the latest version.
(Noticed this because bun 1.0.2 which I had installed reports itself as
Node 18.5.0 which lead to ESM warnings)
Copy file name to clipboardExpand all lines: dev-packages/node-integration-tests/suites/esm/warn-esm/test.ts
+1-2
Original file line number
Diff line number
Diff line change
@@ -5,8 +5,7 @@ afterAll(() => {
5
5
cleanupChildProcesses();
6
6
});
7
7
8
-
constesmWarning=
9
-
'[Sentry] You are using Node.js in ESM mode ("import syntax"). The Sentry Node.js SDK is not compatible with ESM in Node.js versions before 18.19.0 or before 20.6.0. Please either build your application with CommonJS ("require() syntax"), or upgrade your Node.js version.';
8
+
constesmWarning=`[Sentry] You are using Node.js v${process.versions.node} in ESM mode ("import syntax"). The Sentry Node.js SDK is not compatible with ESM in Node.js versions before 18.19.0 or before 20.6.0. Please either build your application with CommonJS ("require() syntax"), or upgrade your Node.js version.`;
10
9
11
10
test("warns if using ESM on Node.js versions that don't support `register()`",async()=>{
Copy file name to clipboardExpand all lines: packages/node/src/sdk/initOtel.ts
+1-1
Original file line number
Diff line number
Diff line change
@@ -59,7 +59,7 @@ export function maybeInitializeEsmLoader(): void {
59
59
consoleSandbox(()=>{
60
60
// eslint-disable-next-line no-console
61
61
console.warn(
62
-
'[Sentry] You are using Node.js in ESM mode ("import syntax"). The Sentry Node.js SDK is not compatible with ESM in Node.js versions before 18.19.0 or before 20.6.0. Please either build your application with CommonJS ("require() syntax"), or upgrade your Node.js version.',
62
+
`[Sentry] You are using Node.js v${process.versions.node}in ESM mode ("import syntax"). The Sentry Node.js SDK is not compatible with ESM in Node.js versions before 18.19.0 or before 20.6.0. Please either build your application with CommonJS ("require() syntax"), or upgrade your Node.js version.`,
0 commit comments