-
-
Notifications
You must be signed in to change notification settings - Fork 607
file history does not follow file renames #1879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Unfortunately the rename detection happens on a diff level which means if we do the fast log walk with path spec filtering we won’t be able to detect renames. We need to actually benchmark this: maybe we just use the full revwalk and filter out diffs not touching the file in question or something more fancy like starting a new revwalk from the commit that does a rename which we can check if we find the added commit of the file |
@extrawurst Did you check what other tools, namely |
Even |
That fact significantly increases my hope that there is a simple way of following renames. :-) |
This comment was marked as outdated.
This comment was marked as outdated.
actually it does exactly what I suspected internally: rev walk starting with
interestingly they do not apply the optimisation that I had in mind: the status of the modification of the file in step 1. can be used to skip 2. if the status is not a file-add because a rename effectively looks like the initial commit of a file (with the new name) |
@cruessler can you pick this up next? it should really be close to finish the PR |
I’ll have a look! |
I just renamed
CHANGELOG.md
to ->CHANGELOG-2.md
and this is how the file history of it looks like:original implementation happened in #381 by @cruessler
The text was updated successfully, but these errors were encountered: