logger: support variable args in New function

* Any integer type will be used as buffer size
* Otherwise it is a config object

Author: unknwon

logger.go

@@ -114,20 +114,44 @@ func init() {
 }
 
 // New initializes and appends a new logger to the managed list.
-// Calling this function multiple times will overwrite previous logger with same mode.
+// Calling this function multiple times will overwrite previous initialized
+// logger with the same mode.
+//
+// Any integer type (i.e. int, int32, int64) will be used as buffer size.
+// Otherwise, the value will be used as config object to the logger.
 //
 // This function is not concurrent safe.
-func New(mode Mode, bufferSize int64, cfg interface{}) error {
+//func New(mode Mode, bufferSize int64, cfg interface{}) error {
+func New(mode Mode, opts ...interface{}) error {
 	r, ok := registers[mode]
 	if !ok {
 		return fmt.Errorf("no register for %q", mode)
 	}
 
+	bufferSize := 0
+	var cfg interface{}
+	for i := range opts {
+		switch opt := opts[i].(type) {
+		case int:
+			bufferSize = opt
+		case int32:
+			bufferSize = int(opt)
+		case int64:
+			bufferSize = int(opt)
+		default:
+			cfg = opt
+		}
+	}
+
 	l, err := r(cfg)
 	if err != nil {
 		return fmt.Errorf("initialize logger: %v", err)
 	}
 
+	if bufferSize < 0 {
+		bufferSize = 0
+	}
+
 	ctx, cancel := context.WithCancel(mgr.ctx)
 	cl := &cancelableLogger{
 		cancel:  cancel,

logger_test.go

@@ -89,14 +89,28 @@ func TestNew(t *testing.T) {
 	)
 
 	tests := []struct {
-		name string
-		mode Mode
-		want error
+		name       string
+		mode       Mode
+		bufferSize interface{}
+		want       error
 	}{
 		{
-			name: "success",
-			mode: testModeGood,
-			want: nil,
+			name:       "success",
+			mode:       testModeGood,
+			bufferSize: 1,
+			want:       nil,
+		},
+		{
+			name:       "success",
+			mode:       testModeGood,
+			bufferSize: int32(1),
+			want:       nil,
+		},
+		{
+			name:       "success",
+			mode:       testModeGood,
+			bufferSize: int64(1),
+			want:       nil,
 		},
 		{
 			name: "no register",
@@ -116,7 +130,7 @@ func TestNew(t *testing.T) {
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			err := New(tt.mode, 10, nil)
+			err := New(tt.mode, tt.bufferSize)
 			assert.Equal(t, tt.want, err)
 		})
 	}
@@ -129,15 +143,15 @@ func TestRemove(t *testing.T) {
 			mode: testMode1,
 		}, nil
 	})
-	assert.Nil(t, New(testMode1, 10, nil))
+	assert.Nil(t, New(testMode1, -1))
 
 	testMode2 := Mode("TestRemove2")
 	NewRegister(testMode2, func(_ interface{}) (Logger, error) {
 		return &noopLogger{
 			mode: testMode2,
 		}, nil
 	})
-	assert.Nil(t, New(testMode2, 10, nil))
+	assert.Nil(t, New(testMode2, -1))
 
 	tests := []struct {
 		name       string