Skip to content

Limit number of files/folders to appear in explorer #10499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 of 7 tasks
Aviortheking opened this issue Feb 27, 2020 · 9 comments
Open
2 of 7 tasks

Limit number of files/folders to appear in explorer #10499

Aviortheking opened this issue Feb 27, 2020 · 9 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality

Comments

@Aviortheking
Copy link

  • Gitea version (or commit ref): 1.12.0+dev-379-ge5944a952
  • Git version: Docker image latest
  • Operating system: Docker image latest
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

Limit the number of files/folders shown at the same time to not cause this VERY long loading time and browser not handling the page correctly

ex: https://git.delta-wings.net/tcgdex/compiled/src/branch/master/en/cards
Github: https://github.com/tcgdex/distribution/tree/master/en/cards
...

Screenshots

@guillep2k guillep2k added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Feb 27, 2020
@6543
Copy link
Member

6543 commented Feb 27, 2020

@Aviortheking this should be only be a problem if you visit a folder the first time after code change: #10069

@Aviortheking
Copy link
Author

It dont seems its doing it as it take a long t'aime to load Evert times

@6543
Copy link
Member

6543 commented Feb 28, 2020

"- COMMITS_COUNT: 1000: Only enable the cache when repository's commits count great than."
you may have to less commits - https://github.com/go-gitea/gitea/pull/10069/files#diff-07e54da65506d1528f7f446c22a6f723R398

but a configruable limit or paginatin would be a enhancement (I personaly prefere a pagination since the other optin will make some things inaccessible)

@guillep2k
Copy link
Member

Performance hits for this page come from two sources: 1) the time required for git to bring up the list and 2) the server/network/client time associated with rendering that list.

AFAIK (1) is the most expensive by far, so only adding pagination wouldn't help much.
For this, #10069 will help.

Paginating will help with (2), certainly, and with the general usability of the feature.

@stale
Copy link

stale bot commented Apr 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Apr 28, 2020
@stale
Copy link

stale bot commented May 13, 2020

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this as completed May 13, 2020
@zeripath zeripath reopened this May 13, 2020
@stale stale bot removed the issue/stale label May 13, 2020
@stale
Copy link

stale bot commented Jul 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Jul 12, 2020
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jul 12, 2020
@stale stale bot removed the issue/stale label Jul 12, 2020
@iamdoubz
Copy link

I would like this to be added as well. For me, I am doing a large ERP upgrade and need to compare Oracle package and package bodies. We currently have over 16,000 files per branch (dev, test, and prod) in the repo and it takes 2268ms for page load and 2034ms for template load. If we could have a configuration that limits to only loading oh let's say 50 files at a time, that would be fantastic.

Do I need to put in a separate ticket?

@Aviortheking
Copy link
Author

It would be cool doing like Github by limiting to 3k files displayed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

6 participants