override git setting to fetch private github dependencies

Author: jirfag

deployments/build_runner/Dockerfile

@@ -25,7 +25,7 @@ RUN curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.s
 
 WORKDIR ${GOPATH}/src/github.com/golangci/golangci-api
 RUN git clone https://github.com/golangci/golangci-api.git . && \
-    git checkout 6ca91c7c462a4441397c61e5cb71949d69622e3f && \
+    git checkout afe3f1fb25f93da45777fd12b042e9671e905bee && \
     GO111MODULE=on go mod vendor && \
     go install ./cmd/buildrunner && \
     go install ./cmd/goenvbuild

pkg/goenvbuild/preparer.go

@@ -155,6 +155,17 @@ func (p Preparer) run(needStreamToOutput bool) *result.Result {
 		return saveErr(err)
 	}
 
+	// setup git
+	privateAccessToken := p.cfg.GetString("PRIVATE_ACCESS_TOKEN")
+	if privateAccessToken != "" {
+		err = runStepGroup(res.Log, "setup git", func(sg *result.StepGroup, log logutil.Log) error {
+			return p.setupGit(ctx, sg, log, runner, privateAccessToken)
+		})
+		if err != nil {
+			return saveErr(err)
+		}
+	}
+
 	// prepare repo
 	err = runStepGroup(res.Log, "prepare repo", func(sg *result.StepGroup, log logutil.Log) error {
 		return p.runPreparation(ctx, sg, log, &res.ServiceConfig, projectPath, runner)
@@ -376,6 +387,19 @@ func (p Preparer) parseGolangciLintVersion(sg *result.StepGroup, log logutil.Log
 	return v, nil
 }
 
+func (p Preparer) setupGit(ctx context.Context, sg *result.StepGroup, log logutil.Log,
+	runner *command.StreamingRunner, privateAccessToken string) error {
+
+	sg.AddStep("setup git overrides for GitHub private dependencies")
+	overridePattern := fmt.Sprintf(`url.https://%[email protected]/.insteadOf`, privateAccessToken)
+	_, err := runner.Run(ctx, "git", "config", "--global", overridePattern, "https://github.com/")
+	if err != nil {
+		return errors.Wrap(err, "failed to setup git overrides")
+	}
+
+	return nil
+}
+
 func (p Preparer) runPreparation(ctx context.Context, sg *result.StepGroup, log logutil.Log,
 	cfg *goenvconfig.Service, projectPath string, runner *command.StreamingRunner) error {
 

pkg/worker/analyze/processors/github_go_pr.go

@@ -336,7 +336,8 @@ func (g githubGoPR) Process(ctx context.Context) error {
 	g.setCommitStatus(ctx, github.StatusPending, "GolangCI is reviewing your Pull Request...")
 
 	startedAt := time.Now()
-	exec, resLog, err := g.workspaceInstaller.Setup(ctx, g.getRepo(), "github.com", g.context.Repo.Owner, g.context.Repo.Name) //nolint:govet
+	exec, resLog, err := g.workspaceInstaller.Setup(ctx, g.context.GithubAccessToken,
+		g.getRepo(), "github.com", g.context.Repo.Owner, g.context.Repo.Name) //nolint:govet
 	if err != nil {
 		analytics.Log(ctx).Warnf("Failed to setup workspace: %s", err)
 		publicError := fmt.Sprintf("failed to setup workspace: %s", err)

pkg/worker/analyze/processors/repo_processor.go

@@ -120,7 +120,7 @@ func (r *Repo) prepare(ctx *RepoContext, res *repoResult) error {
 	defer res.addTimingFrom("Prepare", time.Now())
 
 	fr := buildFetchersRepo(ctx)
-	exec, resLog, err := r.Wi.Setup(ctx.Ctx, fr, "github.com", ctx.Repo.Owner, ctx.Repo.Name)
+	exec, resLog, err := r.Wi.Setup(ctx.Ctx, ctx.PrivateAccessToken, fr, "github.com", ctx.Repo.Owner, ctx.Repo.Name)
 	if err != nil {
 		return errors.Wrap(err, "failed to setup workspace")
 	}

pkg/worker/lib/goutils/workspaces/go.go

@@ -29,12 +29,18 @@ func NewGo(exec executors.Executor, log logutil.Log, repoFetcher fetchers.Fetche
 	}
 }
 
-func (w *Go) Setup(ctx context.Context, repo *fetchers.Repo, projectPathParts ...string) (executors.Executor, *result.Log, error) {
+func (w *Go) Setup(ctx context.Context, privateAccessToken string, repo *fetchers.Repo, projectPathParts ...string) (executors.Executor, *result.Log, error) {
 	if err := w.repoFetcher.Fetch(ctx, repo, w.exec); err != nil {
 		return nil, nil, errors.Wrap(err, "failed to fetch repo")
 	}
 
-	exec := w.exec.WithEnv("REPO", path.Join(projectPathParts...)).WithEnv("FORMAT_JSON", "1")
+	exec := w.exec.
+		WithEnv("REPO", path.Join(projectPathParts...)).
+		WithEnv("FORMAT_JSON", "1")
+	if privateAccessToken != "" {
+		exec = exec.WithEnv("PRIVATE_ACCESS_TOKEN", privateAccessToken)
+	}
+
 	out, err := exec.Run(ctx, "goenvbuild")
 	if err != nil {
 		return nil, nil, errors.Wrap(err, "goenvbuild failed")

pkg/worker/lib/goutils/workspaces/workspace.go

@@ -9,5 +9,5 @@ import (
 )
 
 type Installer interface {
-	Setup(ctx context.Context, repo *fetchers.Repo, projectPathParts ...string) (executors.Executor, *result.Log, error)
+	Setup(ctx context.Context, privateAccessToken string, repo *fetchers.Repo, projectPathParts ...string) (executors.Executor, *result.Log, error)
 }