fix: default value for delegation ratio (OZ L-06)

Signed-off-by: Tomás Migone <[email protected]>

Author: tmigone

packages/horizon/contracts/data-service/utilities/ProvisionManager.sol

@@ -19,6 +19,10 @@ import { ProvisionManagerV1Storage } from "./ProvisionManagerStorage.sol";
  * The parameters are:
  * - Provision parameters (thawing period and verifier cut)
  * - Provision tokens
+ *
+ * Note that default values for all provision parameters provide the most permissive configuration, it's
+ * highly recommended to override them at the data service level.
+ *
  * @custom:security-contact Please email [email protected] if you find any
  * bugs. We may have an active bug bounty program.
  */
@@ -43,6 +47,9 @@ abstract contract ProvisionManager is Initializable, GraphDirectory, ProvisionMa
     /// @notice The default maximum provision tokens.
     uint256 internal constant DEFAULT_MAX_PROVISION_TOKENS = type(uint256).max;
 
+    /// @notice The default delegation ratio.
+    uint32 internal constant DEFAULT_DELEGATION_RATIO = type(uint32).max;
+
     /**
      * @notice Emitted when the provision tokens range is set.
      * @param min The minimum allowed value for the provision tokens.
@@ -138,6 +145,7 @@ abstract contract ProvisionManager is Initializable, GraphDirectory, ProvisionMa
         _setProvisionTokensRange(DEFAULT_MIN_PROVISION_TOKENS, DEFAULT_MAX_PROVISION_TOKENS);
         _setVerifierCutRange(DEFAULT_MIN_VERIFIER_CUT, DEFAULT_MAX_VERIFIER_CUT);
         _setThawingPeriodRange(DEFAULT_MIN_THAWING_PERIOD, DEFAULT_MAX_THAWING_PERIOD);
+        _setDelegationRatio(DEFAULT_DELEGATION_RATIO);
     }
 
     /**

packages/horizon/test/data-service/DataService.t.sol

@@ -20,7 +20,7 @@ contract DataServiceTest is HorizonStakingSharedTest {
     }
 
     function test_Constructor_WhenTheContractIsDeployedWithAValidController() external view {
-        _assert_delegationRatio(type(uint32).min);
+        _assert_delegationRatio(type(uint32).max);
         _assert_provisionTokens_range(type(uint256).min, type(uint256).max);
         _assert_verifierCut_range(type(uint32).min, uint32(PPMMath.MAX_PPM));
         _assert_thawingPeriod_range(type(uint64).min, type(uint64).max);

packages/horizon/test/data-service/DataServiceUpgradeable.t.sol

@@ -14,7 +14,7 @@ contract DataServiceUpgradeableTest is GraphBaseTest {
         // via proxy - ensure that the proxy was initialized correctly
         // these calls validate proxy storage was correctly initialized
         uint32 delegationRatio = dataService.getDelegationRatio();
-        assertEq(delegationRatio, type(uint32).min);
+        assertEq(delegationRatio, type(uint32).max);
 
         (uint256 minTokens, uint256 maxTokens) = dataService.getProvisionTokensRange();
         assertEq(minTokens, type(uint256).min);

packages/horizon/test/data-service/extensions/DataServicePausableUpgradeable.t.sol

@@ -17,7 +17,7 @@ contract DataServicePausableUpgradeableTest is GraphBaseTest {
         // via proxy - ensure that the proxy was initialized correctly
         // these calls validate proxy storage was correctly initialized
         uint32 delegationRatio = dataService.getDelegationRatio();
-        assertEq(delegationRatio, type(uint32).min);
+        assertEq(delegationRatio, type(uint32).max);
 
         (uint256 minTokens, uint256 maxTokens) = dataService.getProvisionTokensRange();
         assertEq(minTokens, type(uint256).min);