Skip to content

Script sync fails with a SyntaxError on logical nullish assignment #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
monk-time opened this issue Apr 9, 2021 · 2 comments
Closed

Comments

@monk-time
Copy link

Same issue as #728 but with logical nullish assignment (ES2021 feature that is already supported by all major browsers) causing script sync to fail with a SyntaxError:

Script sync failed - Code contains errors: Uncaught SyntaxError: Unexpected token '??=' at undefined:1567:36.

https://github.com/JasonBarnabe/greasyfork/blob/17dac187d24a42dc6701216320d9bf868f65ea6b/Gemfile.lock#L233-L234
V8 started supporting this feature at v8.5. mini_racer has an update available (0.4.0.beta1, came out yesterday) where they have switched from libv8 to libv8-node (commit, explanation) which should be enough to fix this issue, node supports this feature since v15+. Meanwhile libv8 hasn't been updated from what you're using.

@JasonBarnabe
Copy link
Collaborator

mini_racer 0.4 is released (but not published?). I'll try it out and use if it works. Thanks for investigating.

@JasonBarnabe
Copy link
Collaborator

Updated to mini_racer 0.4, so you should be good to go now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants