fixup clippy and fmt

Author: dylanlott

src/config.rs

@@ -259,7 +259,7 @@ impl BuilderConfig {
     }
 
     /// Loads the Signet system constants for Pecorino.
-    pub fn load_pecorino_constants(&self) -> SignetSystemConstants {
+    pub const fn load_pecorino_constants(&self) -> SignetSystemConstants {
         let host = HostConfig::new(
             self.host_chain_id,
             149984,

src/tasks/block.rs

@@ -81,7 +81,7 @@ impl BlockBuilder {
         mut bundle_receiver: mpsc::UnboundedReceiver<Bundle>,
         cache: SimCache,
     ) -> JoinHandle<()> {
-        let jh = tokio::spawn(async move {
+        tokio::spawn(async move {
             loop {
                 select! {
                     maybe_tx = tx_receiver.recv() => {
@@ -96,8 +96,7 @@ impl BlockBuilder {
                     }
                 }
             }
-        });
-        jh
+        })
     }
 
     /// Spawns the block building task.
@@ -107,7 +106,7 @@ impl BlockBuilder {
         cache: SimCache,
         submit_sender: mpsc::UnboundedSender<BuiltBlock>,
     ) -> JoinHandle<()> {
-        let jh = tokio::spawn(async move {
+        tokio::spawn(async move {
             loop {
                 let sim_cache = cache.clone();
 
@@ -126,8 +125,7 @@ impl BlockBuilder {
                     }
                 }
             }
-        });
-        jh
+        })
     }
 
     /// Returns the instant at which simulation must stop.

tests/block_builder_test.rs

@@ -17,6 +17,7 @@ mod tests {
     };
     use tokio::{sync::mpsc::unbounded_channel, time::timeout};
 
+    /// Tests a single block build.
     #[tokio::test(flavor = "multi_thread", worker_threads = 2)]
     async fn test_handle_build() {
         setup_logging();
@@ -100,12 +101,12 @@ mod tests {
         let builder = Arc::new(BlockBuilder::new(&config, ru_provider.clone(), slot_calculator));
 
         // Create a sim cache and start filling it with items
-        let _ =
-            builder.clone().spawn_cache_handler(tx_receiver, bundle_receiver, sim_cache.clone());
+        builder.clone().spawn_cache_handler(tx_receiver, bundle_receiver, sim_cache.clone());
 
         // Finally, Kick off the block builder task.
-        let _ = builder.clone().spawn_builder_task(constants, sim_cache.clone(), block_sender);
+        builder.clone().spawn_builder_task(constants, sim_cache.clone(), block_sender);
 
+        // Feed in transactions to the tx_sender and wait for the block to be simulated
         let tx_1 = new_signed_tx(&test_key_0, 0, U256::from(1_f64), 11_000).unwrap();
         let tx_2 = new_signed_tx(&test_key_1, 0, U256::from(2_f64), 10_000).unwrap();
         tx_sender.send(tx_1).unwrap();
@@ -114,8 +115,9 @@ mod tests {
         // Wait for a block with timeout
         let result = timeout(Duration::from_secs(5), block_receiver.recv()).await;
         assert!(result.is_ok(), "Did not receive block within 5 seconds");
+
+        // Assert on the block
         let block = result.unwrap();
-        dbg!(&block);
         assert!(block.is_some(), "Block channel closed without receiving a block");
         assert!(block.unwrap().tx_count() == 2); // TODO: Why is this failing? I'm seeing EVM errors but haven't tracked them down yet. 
     }