chore(logging): don't log warning about multiple class declarations in a file

danbucholtz · danbucholtz · commit 44e8bd983686 · 2017-03-27T11:03:05.000-05:00
diff --git a/src/util/typescript-utils.ts b/src/util/typescript-utils.ts
@@ -161,13 +161,7 @@ export function checkIfFunctionIsCalled(filePath: string, fileContent: string, f
 }
 
 export function getClassDeclarations(sourceFile: SourceFile) {
-  const classDeclarations = findNodes(sourceFile, sourceFile, SyntaxKind.ClassDeclaration, true) as ClassDeclaration[];
-  if (classDeclarations.length > 1) {
-    Logger.warn(`The following file has multiple class declarations in it:
-${sourceFile.fileName}
-In general, it's considered a best practice to have at most one class declaration per file.`);
-  }
-  return classDeclarations;
+  return findNodes(sourceFile, sourceFile, SyntaxKind.ClassDeclaration, true) as ClassDeclaration[];
 }
 
 export function getNgModuleClassName(filePath: string, fileContent: string) {

Original file line number	Diff line number	Diff line change
`@@ -161,13 +161,7 @@ export function checkIfFunctionIsCalled(filePath: string, fileContent: string, f`
`161`	`161`	`}`
`162`	`162`
`163`	`163`	`export function getClassDeclarations(sourceFile: SourceFile) {`
`164`		`- const classDeclarations = findNodes(sourceFile, sourceFile, SyntaxKind.ClassDeclaration, true) as ClassDeclaration[];`
`165`		`- if (classDeclarations.length > 1) {`
`166`		- Logger.warn(`The following file has multiple class declarations in it:
`167`		`-${sourceFile.fileName}`
`168`		-In general, it's considered a best practice to have at most one class declaration per file.`);
`169`		`- }`
`170`		`- return classDeclarations;`
	`164`	`+ return findNodes(sourceFile, sourceFile, SyntaxKind.ClassDeclaration, true) as ClassDeclaration[];`
`171`	`165`	`}`
`172`	`166`
`173`	`167`	`export function getNgModuleClassName(filePath: string, fileContent: string) {`