Skip to content

Stripping .git from the module name #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
God-damnit-all opened this issue Sep 17, 2021 · 1 comment · May be fixed by #50
Open

Stripping .git from the module name #48

God-damnit-all opened this issue Sep 17, 2021 · 1 comment · May be fixed by #50

Comments

@God-damnit-all
Copy link

God-damnit-all commented Sep 17, 2021 •
edited
Loading

(Get-GitModule 'https://github.com/riedyw/PoshFunctions.git').Name returns PoshFunctions.git, which means the end of the module path ends as Modules/PoshFunctions.git - however, I'd prefer it to be Modules/PoshFunctions instead.

Since -DestinationPath is only for specifying a root directory, it would be nice if there were an option to manually specify what name I want the module to have and/or an option to strip the .git portion off the folder name.
@God-damnit-all God-damnit-all changed the title Stripping .git from the Stripping .git from the module name Sep 17, 2021
@God-damnit-all
Copy link
Author

I just realized that Get-GitModule 'https://github.com/riedyw/PoshFunctions' works, and returns PoshFunctions. It is a force of habit for me to use the .git URL.

Perhaps stripping the .git from the Name should be the default behavior.

@God-damnit-all God-damnit-all linked a pull request Dec 23, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Strip .git from $ModuleName God-damnit-all/InstallModuleFromGit
1 participant
@God-damnit-all