Skip to content

Commit eb3497a

Browse files
committed
Using C_STANDARD 99
Use consistence CMAKE_TOOLCHAIN_FILE Signed-off-by: Yonggang Luo <[email protected]>
1 parent d5e45bc commit eb3497a

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

cmake/iotjs.cmake

+2-1
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ endforeach()
350350
iotjs_add_compile_flags(-Wall)
351351
if(NOT USING_MSVC)
352352
iotjs_add_compile_flags(-Wextra -Werror -Wno-unused-parameter)
353-
iotjs_add_compile_flags(-Wsign-conversion -std=gnu99)
353+
iotjs_add_compile_flags(-Wno-sizeof-pointer-memaccess -Wno-unused-variable)
354354
endif()
355355

356356
if(ENABLE_SNAPSHOT)
@@ -536,6 +536,7 @@ set_target_properties(${TARGET_LIB_IOTJS} PROPERTIES
536536
ARCHIVE_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/lib"
537537
LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/lib"
538538
PUBLIC_HEADER "${IOTJS_PUBLIC_HEADERS}"
539+
C_STANDARD 99
539540
)
540541
target_include_directories(${TARGET_LIB_IOTJS}
541542
PRIVATE ${IOTJS_INCLUDE_DIRS})

cmake/libtuv.cmake

+1-4
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,6 @@ if("${TARGET_OS}" STREQUAL "MOCK")
2222
else()
2323
string(TOLOWER ${TARGET_ARCH}-${TARGET_OS} PLATFORM_DESCRIPTOR)
2424
endif()
25-
set(DEPS_TUV_TOOLCHAIN
26-
${DEPS_TUV_SRC}/cmake/config/config_${PLATFORM_DESCRIPTOR}.cmake)
27-
message(STATUS "libtuv toolchain file: ${DEPS_TUV_TOOLCHAIN}")
2825
ExternalProject_Add(libtuv
2926
PREFIX ${DEPS_TUV}
3027
SOURCE_DIR ${DEPS_TUV_SRC}
@@ -35,7 +32,7 @@ ExternalProject_Add(libtuv
3532
${CMAKE_BINARY_DIR}/${DEPS_TUV}/lib/${CONFIG_TYPE}/
3633
${CMAKE_BINARY_DIR}/lib/
3734
CMAKE_ARGS
38-
-DCMAKE_TOOLCHAIN_FILE=${DEPS_TUV_TOOLCHAIN}
35+
-DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE}
3936
-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
4037
-DCMAKE_C_FLAGS=${CMAKE_C_FLAGS}
4138
-DTARGET_PLATFORM=${PLATFORM_DESCRIPTOR}

0 commit comments

Comments
 (0)